Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secrets usage #75

Closed
gentlementlegen opened this issue Nov 8, 2024 · 5 comments · Fixed by #76
Closed

Fix secrets usage #75

gentlementlegen opened this issue Nov 8, 2024 · 5 comments · Fixed by #76

Comments

@gentlementlegen
Copy link
Member

          @0x4007 I should have tested this, but it will always crash if a user opens a pull request because it uses variables from secrets that are not accessible, I will fix that.

Originally posted by @gentlementlegen in #31 (comment)

Many variables of the script reference secrets, which do not exist on PRs for security reasons. They have to be replaced or default to something for graceful fallback.

Copy link

ubiquity-os bot commented Nov 8, 2024

! No price label is set to calculate the duration

1 similar comment
Copy link

ubiquity-os bot commented Nov 8, 2024

! No price label is set to calculate the duration

@gentlementlegen gentlementlegen self-assigned this Nov 8, 2024
Copy link

ubiquity-os bot commented Nov 8, 2024

@gentlementlegen the deadline is at Fri, Nov 8, 9:08 AM UTC

@0x4007
Copy link
Member

0x4007 commented Nov 8, 2024

! No price label is set to calculate the duration

This error doesn't make sense it should be removed.

Copy link

ubiquity-os bot commented Nov 10, 2024

 [ 17.76 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask16
IssueSpecification111.76
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 I should have tested this, but it will always crash if a…
3.92
content:
  content:
    p:
      score: 0
      elementCount: 3
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 75
  wordValue: 0.1
  result: 3.92
111.76
Resolves #75QA: https://github.com/ubiquity-os/plugin-sdk/acti…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 17
  wordValue: 0
  result: 0
0.20

 [ 0.426 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment10.426
Conversation Incentives
CommentFormattingRelevanceReward
This error doesn't make sense it should be removed.
0.71
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0.1
  result: 0.71
0.60.426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants