Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments are not posted on pull requests #10

Closed
0x4007 opened this issue Jan 30, 2024 · 6 comments
Closed

Deployments are not posted on pull requests #10

0x4007 opened this issue Jan 30, 2024 · 6 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Jan 30, 2024

We already implemented this logic on the Ubiquity Dollar and pay.ubq.fi repositories, but it seems that it was overlooked within this template. The purpose of this is for reviewers to easily be able to review the work.

Example deployment comment: ubiquity/pay.ubq.fi#148 (comment)

  1. Make sure to copy the code so that it works from this template.
  2. It seems sloppy. Refactor the code to be clean and all in TypeScript (or inside of GitHub Actions whatever makes more sense) and neatly organized inside of the .github directory.
  3. I can't find the example, but I realized that the commits are actually posting in reverse chronological order. This must be fixed.
@0x4007
Copy link
Member Author

0x4007 commented Feb 19, 2024

/start

Copy link

ubiquibot bot commented Feb 19, 2024

DeadlineMon, Feb 19, 4:06 PM UTC
Registered Wallet 0x4007CE2083c7F3E18097aeB3A39bb8eC149a341d
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member Author

0x4007 commented Feb 19, 2024

Kind of very messy, took me apparently about 10 hours to do, but here's the final result. Comments and pull requests supported:

6eb4ace#comments

@0x4007 0x4007 closed this as completed Feb 19, 2024
Copy link

ubiquibot bot commented Feb 19, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Feb 19, 2024

[ 240.8 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification135.4
IssueTask1.00200
IssueComment15.4
IssueComment10
Conversation Incentives
CommentFormattingRelevanceReward
We already implemented this logic on the Ubiquity Dollar and pay...
35.4
li:
  count: 5
  score: "5"
  words: 83
code:
  count: 1
  score: "1"
  words: 1
135.4
Kind of very messy, took me apparently about 10 hours to do, but...
5.40.225.4
Kind of very messy, took me apparently about 10 hours to do, but...
-0.22-

@0x4007
Copy link
Member Author

0x4007 commented Feb 21, 2024

Just got it finalized. Was testing on this pull request, but the code changes are done on @ubiquity/cloudflare-continuous-deploys: #14 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant