Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Linkback Fix #45

Closed
0x4007 opened this issue Oct 8, 2024 · 7 comments · Fixed by ubiquity/devpool-directory#1693
Closed

Fork Linkback Fix #45

0x4007 opened this issue Oct 8, 2024 · 7 comments · Fixed by ubiquity/devpool-directory#1693

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 8, 2024

Yes but to clarify this used to work as expected. The problem now is that it seems when the task is assigned and unassigned, it links back even on forks.

So the issue is:

  1. New devpool issue is created
  2. Fork of https://github.com/ubiquity/devpool-directory creates a new issue with www prefix (which is expected) in order not to reference (i.e. spam) the original issue (example)
  3. Devpool issue is closed because somebody was assigned
  4. Devpool issue is reopened because somebody was unassigned
  5. Now the forked issue displays github issue URL without the www prefix (while expected behavior to display URL with the www prefix) thus spamming original issue (example)

https://github.com/jordan-ae/devpool-directory/issues/867

When it is reopened, it writes the non www. prefixed link to the issue, which "references" the original issue which appears as spam

image

github com_ubiquity_ubiquity-dollar_issues_937

This comment was marked as outdated.

@rndquu
Copy link
Member

rndquu commented Oct 8, 2024

So:

  1. https://github.com/ubiquity/devpool-directory should reference github issues without the www prefix (which works as expected right now)
  2. Forks of https://github.com/ubiquity/devpool-directory should reference github issues with the www prefix in order not to spam original issues

Correct?

@0x4007
Copy link
Member Author

0x4007 commented Oct 8, 2024

Yes but to clarify this used to work as expected. The problem now is that it seems when the task is assigned and unassigned, it links back even on forks.

@rndquu
Copy link
Member

rndquu commented Oct 8, 2024

Yes but to clarify this used to work as expected. The problem now is that it seems when the task is assigned and unassigned, it links back even on forks.

So the issue is:

  1. New devpool issue is created
  2. Fork of https://github.com/ubiquity/devpool-directory creates a new issue with www prefix (which is expected) in order not to reference (i.e. spam) the original issue (example)
  3. Devpool issue is closed because somebody was assigned
  4. Devpool issue is reopened because somebody was unassigned
  5. Now the forked issue displays github issue URL without the www prefix (while expected behavior to display URL with the www prefix) thus spamming original issue (example)

Copy link

ubiquity-os bot commented Oct 18, 2024

 [ 175.54 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueTask1100
IssueSpecification173.92
IssueComment11.62
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
So the issue is:1. New devpool issue is created2. Fork of ht…
24.64
content:
  content:
    p:
      score: 0
      elementCount: 10
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    a:
      score: 5
      elementCount: 2
    hr:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 18.5
regex:
  wordCount: 127
  wordValue: 0.1
  result: 6.14
173.92
Yes but to clarify this used to work as expected. The problem no…
1.8
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 30
  wordValue: 0.1
  result: 1.8
0.91.62
Had to do a refactoring, and for thorough testing I had to knock…
17
content:
  content:
    p:
      score: 0
      elementCount: 4
    ul:
      score: 1
      elementCount: 4
    li:
      score: 0.5
      elementCount: 6
    a:
      score: 5
      elementCount: 2
  result: 17
regex:
  wordCount: 112
  wordValue: 0
  result: 0
0.80

 [ 21.56 WXDAI ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment221.56
Conversation Incentives
CommentFormattingRelevanceReward
So:1. https://github.com/ubiquity/devpool-directory should ref…
4.45
content:
  content:
    p:
      score: 0
      elementCount: 4
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
  result: 2
regex:
  wordCount: 43
  wordValue: 0.1
  result: 2.45
0.83.96
So the issue is:1. New devpool issue is created2. Fork of ht…
17.6
content:
  content:
    p:
      score: 0
      elementCount: 6
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    a:
      score: 5
      elementCount: 2
  result: 13.5
regex:
  wordCount: 79
  wordValue: 0.1
  result: 4.1
117.6

@0x4007 0x4007 self-assigned this Oct 18, 2024
Copy link

ubiquity-os bot commented Oct 18, 2024

@0x4007 the deadline is at Fri, Oct 18, 1:22 AM UTC

@0x4007 0x4007 reopened this Oct 18, 2024
@0x4007 0x4007 closed this as completed Oct 18, 2024
Copy link

ubiquity-os bot commented Oct 18, 2024

 [ 175.54 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueTask1100
IssueSpecification173.92
IssueComment11.62
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
So the issue is:1. New devpool issue is created2. Fork of ht…
24.64
content:
  content:
    p:
      score: 0
      elementCount: 10
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    a:
      score: 5
      elementCount: 2
    hr:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 18.5
regex:
  wordCount: 127
  wordValue: 0.1
  result: 6.14
173.92
Yes but to clarify this used to work as expected. The problem no…
1.8
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 30
  wordValue: 0.1
  result: 1.8
0.91.62
Had to do a refactoring, and for thorough testing I had to knock…
17
content:
  content:
    p:
      score: 0
      elementCount: 4
    ul:
      score: 1
      elementCount: 4
    li:
      score: 0.5
      elementCount: 6
    a:
      score: 5
      elementCount: 2
  result: 17
regex:
  wordCount: 112
  wordValue: 0
  result: 0
0.80

 [ 21.4775 WXDAI ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment221.4775
Conversation Incentives
CommentFormattingRelevanceReward
So:1. https://github.com/ubiquity/devpool-directory should ref…
4.45
content:
  content:
    p:
      score: 0
      elementCount: 4
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
  result: 2
regex:
  wordCount: 43
  wordValue: 0.1
  result: 2.45
0.854.0825
So the issue is:1. New devpool issue is created2. Fork of ht…
17.6
content:
  content:
    p:
      score: 0
      elementCount: 6
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    a:
      score: 5
      elementCount: 2
  result: 13.5
regex:
  wordCount: 79
  wordValue: 0.1
  result: 4.1
0.9517.395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants