fix: returnDataToKernel #44
Conversation
| return contentWithoutFootnotes; | ||
| } | ||
|
|
||
| export function removeCautionMessages(content: string): string { | ||
| const cautionRegex = />[!CAUTION]\n> This issue may be a duplicate of the following issues:\n((> - \[[^\]]+\]\([^)]+\)\n)+)/g; |
There was a problem hiding this comment.
What are these checks? Seems like wrong approach to be doing this. I would expect you should be able to select the right data in the first place and process less comments with a better strategy, although I don't understand the full context of this process here.
There was a problem hiding this comment.
These checks are in place to avoid generating embeddings for comment or issue bodies that include footnotes or caution messages.
There was a problem hiding this comment.
Just ignore every bot comment is my point
There was a problem hiding this comment.
Yes, but when the user updates an issue, it includes footnotes and a caution statement. Should these be propagated to the database as well? I think bot actions are ignored by the kernel.
| } | ||
| if (data && data.length > 0) { | ||
| this.context.logger.info("Comment already exists"); |
There was a problem hiding this comment.
You should be able to just throw this, then it logs and halts function execution.
There was a problem hiding this comment.
I'm not sure I understand what you're suggesting. Are you asking if I should log a fatal error instead of throwing a new one to halt the function execution?
There was a problem hiding this comment.
You can just throw logger.fatal so you get the log displayed and the error caught on a higher level of execution.
Resolves #43
GITHUB_TOKENin compute.yml