Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boosting All Rewards Based On Priority #175

Open
0x4007 opened this issue Sep 8, 2024 · 28 comments · May be fixed by #176
Open

Boosting All Rewards Based On Priority #175

0x4007 opened this issue Sep 8, 2024 · 28 comments · May be fixed by #176

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 8, 2024

We should boost all the rewards proportionally if it's an urgent task. This will incentivize all contributors (not just the assignee) to focus on that task because everybody gets higher rewards for work like reviews.

The higher the priority level the higher the rewards multiplier is for everybody.

example

I should've received a reward closer to $150 in this task, because the priority level was 3.

@0x4007
Copy link
Member Author

0x4007 commented Sep 8, 2024

RFC @gentlementlegen

I have a feeling that with our current infrastructure it doesn't directly support this plugin to affect the reward amount of others, such as conversation rewards.

We need to support outputting rewards from all plugins and aggregating them before sending the sum total to permit generation. ubiquity-os/permit-generation#3

I suppose this proposal implies that we will need to support multiplication as well.

@gentlementlegen
Copy link
Member

Assisitive pricing aims the handle pricing labels and allowing users to modify these labels. There is not calculation on the final reward here. I think this should be handled in conversation rewards.

@0x4007
Copy link
Member Author

0x4007 commented Sep 9, 2024

I see what you mean but logically seems more straightforward if a plugin has the ability to affect all the others' pricing either with addition or multiplication.

Then we don't have to change every plugin, we only need to change this one and the permit generation one to support macro change outputs from any plugin

I suppose it's simpler to implement if we change every plugin though, just not as elegant.

@gentlementlegen
Copy link
Member

Yes I do agree that we should be able to chain these results. It's just that this plugin never had the capability to actually attribute rewards to a user, this was the responsibility of conversation-rewards. We could think of splitting this and have the logic here later on.

@0x4007
Copy link
Member Author

0x4007 commented Sep 9, 2024

If you could write a spec, that would be helpful because I don't have enough context on the problem

@0x4007
Copy link
Member Author

0x4007 commented Sep 10, 2024

@gentlementlegen can you write the spec?

@gentlementlegen
Copy link
Member

@0x4007 Done, let me know if this is clear enough.

@ishowvel
Copy link

Which plugin handles the final permit generation which combines all the rewards?
I was thinking we can just find the priority label using the payload and just multiply the combined rewards by it

@ishowvel
Copy link

/start

Copy link

Warning! This task was created over 49 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Tue, Oct 29, 6:15 AM UTC
Beneficiary 0x340D8d2bd82dEb4f485623453c9F6ad307e6B027

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@ishowvel
Copy link

/stop

@0x4007
Copy link
Member Author

0x4007 commented Oct 28, 2024

Which plugin handles the final permit generation which combines all the rewards?
I was thinking we can just find the priority label using the payload and just multiply the combined rewards by it

Right now it's text-conversation-rewards

Hopefully soon we can upgrade the system to make "permit requests" and every plugin will have a standardized way to send a request to the permit generation module/plugin/endpoint.

@ishowvel
Copy link

Which plugin handles the final permit generation which combines all the rewards?
I was thinking we can just find the priority label using the payload and just multiply the combined rewards by it

Right now it's text-conversation-rewards

Hopefully soon we can upgrade the system to make "permit requests" and every plugin will have a standardized way to send a request to the permit generation module/plugin/endpoint.

shouldnt this spec be moved to text-conversation rewards for now for a fix and then later a better way can hopefully be found?

@0x4007
Copy link
Member Author

0x4007 commented Oct 28, 2024

@gentlementlegen rfc

@gentlementlegen
Copy link
Member

We can do that, you can also cross-reference issues from another repo, either works.

@0x4007
Copy link
Member Author

0x4007 commented Oct 28, 2024

you can also cross-reference issues from another repo, either works.

I don't understand

@gentlementlegen
Copy link
Member

I meant doing the pull-request in text-conversation-rewards and mark it as Resolves https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/175

@ishowvel
Copy link

Like how it's done for devpool directory right?

@ishowvel
Copy link

Making a pull request to the code base while marking it to resolve the issue in the dedicated issue repo for the devpool directory

@gentlementlegen gentlementlegen transferred this issue from ubiquity-os-marketplace/daemon-pricing Oct 28, 2024
@ishowvel
Copy link

/start

Copy link

! ishowvel you were previously unassigned from this task. You cannot be reassigned.

Copy link

@ishowvel the deadline is at Tue, Oct 29, 11:04 PM UTC

@ishowvel
Copy link

is there a way to qa without needing to get an openai api token

@gentlementlegen
Copy link
Member

@ishowvel You can either use a free endpoint, use mocks, or hardcode the evaluation for your testing.

@ishowvel
Copy link

@gentlementlegen would hardcoding the evaluation to be one for each comment be a good idea?
i did it this way

comments.forEach(v => commentRelevances[v.id] = 1)
prComments.forEach(v => prCommentRelevances[v.id] = 1)

@ishowvel
Copy link

also it would very awesome if someone could make the openai implementation optional which will just make all relevances equal to 1

@ishowvel
Copy link

https://github.com/ishowvel/text-conversation-rewards/actions/runs/11616689662/job/32350211337
why does the plugin think i have missing / invalid config.
i have the x25519 pv key, supabase url and key in the repo secrets and evm encrypted key in here

@gentlementlegen
Copy link
Member

@ishowvel You can check the tests where the evaluation is mocked. To test I usually use a free endpoint. You can also start a local mock of OpenAi, you can find a few a GitHub.

Not sure for the configuration, you can print the detailed errors to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants