Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only admin can generate rewards non collaboratively #160

Open
0x4007 opened this issue Oct 16, 2024 · 5 comments · May be fixed by #182
Open

Only admin can generate rewards non collaboratively #160

0x4007 opened this issue Oct 16, 2024 · 5 comments · May be fixed by #182

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 16, 2024

Occasionally there are instances where trusted contributors:

  1. File the spec
  2. Price the issue (they add both time and priority)
  3. Self assign
  4. Self merge.
    If theres no other collaborator involved in any part of this process, we should refuse to generate the reward until somebody else steps in to reopen and close at least.
    Unfortunately after the pull is merged we cant leave a review state other than commented, and it doesnt make sense to change the labels or spec either.

Only admins and billing managers should have this capability. I definitely need it for demo purposes when pitching.

@ishowvel
Copy link

ishowvel commented Nov 5, 2024

Don't you have to be an admin to set price and time priority.
Also would a valid fix to not generate rewards if the event actor of the issue closer is the same as the assignee and the price was also set by the assignee

@ishowvel
Copy link

ishowvel commented Nov 7, 2024

/start

Copy link

Deadline Thu, Nov 7, 9:27 AM UTC
Beneficiary 0x340D8d2bd82dEb4f485623453c9F6ad307e6B027

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member Author

0x4007 commented Nov 8, 2024

Don't you have to be an admin to set price and time priority.

Any collaborator can set a label

Also would a valid fix to not generate rewards if the event actor of the issue closer is the same as the assignee and the price was also set by the assignee

This is unclear but throw an error when the author closes the issue, and they are not an admin/billing_manager

We should also check that a collaborator approved the pull review. If so then we can make an exception and generate rewards

@ishowvel
Copy link

ishowvel commented Nov 8, 2024

Don't you have to be an admin to set price and time priority.

Any collaborator can set a label

Also would a valid fix to not generate rewards if the event actor of the issue closer is the same as the assignee and the price was also set by the assignee

This is unclear but throw an error when the author closes the issue, and they are not an admin/billing_manager

I chose to just not generate a permit if the issue author and assignee are the same and issue the author himself as closed the issue as completed (the issue author also set the pricing labels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants