You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a scenario where a pull-request can have all the validations from the reviewers but won't get merged because the amount of reviewers is under the amount of required reviewers.
Example
A review has 2 validations out of 2 reviewers, but 3 are required.
Possible solutions
Merge when 100% of reviewers validated
Pros:
avoids the automated merging to be stuck
doesn't require multiple validations on small / simple tasks
Cons:
dangerous, even more for outsider pull-requests, that could be merged only with one validation
could be missed by the team that wouldn't notice the merging happening
Post a message saying that the PR can be merged, but requires n more reviewers
Pros:
safe, wouldn't automatically merge the pull-request without meeting the requirements
could even notify the team about the required reviews
There is a scenario where a pull-request can have all the validations from the reviewers but won't get merged because the amount of reviewers is under the amount of required reviewers.
Example
A review has 2 validations out of 2 reviewers, but 3 are required.
Possible solutions
Merge when 100% of reviewers validated
Pros:
Cons:
Post a message saying that the PR can be merged, but requires
n
more reviewersPros:
Cons:
Partially relates to #5
The text was updated successfully, but these errors were encountered: