-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving styling and using ready components (i.e Material UI) #447
Comments
Or please add |
Any directions on how can I add the renderInput ? I've explored the project and I'm still thinking about how would you prefer this to be added. Any thoughts to make my life easier. I'd love to create a PR after some directions. @ro-ka |
This would be useful to us too - adding a |
Do you have a proposal on how to add this? Will this be needed for the suggest items, too? Would it work to allow to pass in a Input component, e.g. from Material UI and enhance it with the things we need? |
I know this isnt exactly what you are after but I suggest styles components.
|
@ro-ka Up for grabs? |
Still not sure on how to implement this non-breaking. Did you know that there is an Autocomplete for Material UI, too? They even provide a Google Maps example. |
@ro-ka It's not about Material UI, i think. It's more about providing control to the Developer who wants to the components. We should atleast provide devs with demos on how to achieve that. |
You’re free to add some demos! I think covering all the various UI kits is tedious work to keep it up to date. |
Problem
Styling is so difficult here especially when trying to work with design system components such as Material UI #437 .
Suggested solution
The solution that I suggest is to expose the input and suggestion list in the component rather than wrapping it inside the
GeoSuggest
component. The react-places-autocomplete does this well but this package is much more complete than the other one which feels abandoned.The text was updated successfully, but these errors were encountered: