Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture UI bugs when multiple have the same label #434

Open
mattnish opened this issue May 27, 2019 · 2 comments
Open

Fixture UI bugs when multiple have the same label #434

mattnish opened this issue May 27, 2019 · 2 comments

Comments

@mattnish
Copy link

mattnish commented May 27, 2019

Short description

I have a number of fixtures with the same label but different lng/lat. In this scenario, a few issues arise:

1. Highlighting using the arrow keys selects all suggestions at once.

Screenshot 2019-05-27 17 20 50

2. Fixtures used as suggestions aren't cleared out properly. In this screenshot, I have maxFixtures set to 3 and changing the search continues adding to the list of previously shown fixture suggestions.

Screenshot 2019-05-27 17 22 17

Expected results

I expected that the fixures suggestions would highlight correctly and be cleared correctly, even though the suggestion labels are the same.

Reproduction steps

  1. Add 3 fixtures with the same label, 2 with another label and set a maxFixtures to 2
  2. Search the 1st label of the fixtures
  3. Arrow down to highlight to reproduce the highlighting bug
  4. Clear input and search by the 2nd label name to reproduce the bug with the previous suggestions

Additional Information

I tried setting the param placeId along with label/location to give the object a unique token but it was ignored and continued relying on the label.

@plumdumpling
Copy link
Contributor

Using unique placeIds should work. At least it works for me with the latest version of the package. @mattnish have you tried this again?

@mattnish
Copy link
Author

mattnish commented Aug 9, 2023

Thanks @plumdumpling will try that out next time I take a look here 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants