Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt, don't back up passwords & keys #574

Open
oakkitten opened this issue Feb 15, 2024 · 0 comments · May be fixed by #576
Open

Encrypt, don't back up passwords & keys #574

oakkitten opened this issue Feb 15, 2024 · 0 comments · May be fixed by #576

Comments

@oakkitten
Copy link
Collaborator

oakkitten commented Feb 15, 2024

Looking at how I seem to have figured out a way to upgrade to AGP 8, and not downgrade sshlib while being able to import tink, I think I want to try to polish and merge my earlier experiment of partial encryption of the preferences. The encrypted preferences would be stored in a file, encrypted with a hardware-based key, which should be as good as we can hope for. These preferences can't be restored from a backup due to the irretrievable nature of the key.

This issue is for discussing what exactly we want to encrypt. My current idea would be:

  • Relay password
  • SSH password
  • SSH key (on supported hardware the key is already stored in hardware, but notably Ed25519 keys are stored by serializing them)
  • Client SSL certificate We only store these in AKS, not SP
  • Media upload basic auth password

Thumbs if agreed, comment otherwise. Note, however, that hosts, usernames, additional fields and headers in the File sharing section are also potentially sensitive information.

ETA: We are also saving open buffers, sent messages, input history, caching media fetch attempts, uploads, and have some internally used (on-device) statistics for sorting shortcuts, etc.

@oakkitten oakkitten linked a pull request Feb 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant