You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
We saw an issue where the peer list was polluted with non-Hyperbahn peers (#464) and the periodic advertise kept failing, but the process stayed up.
At this point the process was hosed since all calls were failing. If some K advertises fail in a row, it probably means we should stop receiving requests.
We saw an issue where the peer list was polluted with non-Hyperbahn peers (#464) and the periodic advertise kept failing, but the process stayed up.
At this point the process was hosed since all calls were failing. If some K advertises fail in a row, it probably means we should stop receiving requests.
Here is tchannel-go's implementation:
https://github.com/uber/tchannel-go/blob/dev/hyperbahn/advertise.go#L31
If we get 5 consecutive failures, we will fatal (unless the user sets a custom FailStrategy, the default is to fatal).
The text was updated successfully, but these errors were encountered: