Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

When the periodic advertise fails continuously, we should kill the process #468

Open
prashantv opened this issue Dec 10, 2016 · 0 comments

Comments

@prashantv
Copy link

We saw an issue where the peer list was polluted with non-Hyperbahn peers (#464) and the periodic advertise kept failing, but the process stayed up.

At this point the process was hosed since all calls were failing. If some K advertises fail in a row, it probably means we should stop receiving requests.

Here is tchannel-go's implementation:
https://github.com/uber/tchannel-go/blob/dev/hyperbahn/advertise.go#L31

If we get 5 consecutive failures, we will fatal (unless the user sets a custom FailStrategy, the default is to fatal).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant