Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate types, generated code with @MainActor #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vsanthanam
Copy link
Member

Proof of concept to allow UIKit dependencies to exist in the DI graph with with Swift Concurrency

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wbond
Copy link
Collaborator

wbond commented Jul 6, 2022

It looks like to do this we'll need to drop support for Swift < 5.5.

I'm rather inclined to drop support for Swift 5.2-5.4 instead of trying to support them via compiler directives.

There will be some updates in Generator/Package.swift and .github/workflows/ci.yml. There are likely going to be updates to the CI in #416, so perhaps wait until that lands.

@tinder-igornovik
Copy link

@vsanthanam is there any way we can merge it?
Tinder iOS team is migrating some stuff to support Swift Concurrency and looks like we need this changes.
Would you be able to merge them in? Thanks.

@tinder-cfuller
Copy link

See #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants