Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Code doesn't work with actor annotated dependencies #422

Open
vsanthanam opened this issue Jun 17, 2022 · 1 comment
Open

Generated Code doesn't work with actor annotated dependencies #422

vsanthanam opened this issue Jun 17, 2022 · 1 comment

Comments

@vsanthanam
Copy link
Member

vsanthanam commented Jun 17, 2022

@MainActor annotated dependencies, produce uncompilable code

To support all actor annotations, I think the solution here is to make the getters for those dependencies async,

to support just @MainActor, we could just require that dependency access happen on the main thread by Component, Dependency, and generated code with @MainActor

@vsanthanam
Copy link
Member Author

Create a proof of concept PR #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant