Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cmake-format on all CMake files #936

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Oct 20, 2024

We could choose to enforce this in CI, but not sure the format is sufficiently better to do that & require everyone run it

Here is the command used:

cmake-format CMakeLists.txt CMakeTests.cmake cmake/Config.cmake.in cmake/TestWrapValgrind.cmake tests/cli/*.txt -i

@dfellis
Copy link
Collaborator

dfellis commented Oct 20, 2024

This PR misses all of the cmake text in /tests/cli. Perhaps we should rename them to *.cmake and modify the macro embedding them to use that new extension instead of *.txt?

@coveralls
Copy link

coveralls commented Oct 20, 2024

Coverage Status

coverage: 98.782%. remained the same
when pulling a62a597 on isaacbrodsky:cmake-format
into 5d5ad33 on uber:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants