-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added error codes #73
base: master
Are you sure you want to change the base?
Changes from 33 commits
0e3ea80
d6cba0d
7951f80
1ec8c63
c20b289
f25e167
7566a22
8d6c553
7c0f6c1
b17ff4a
e44f8eb
5c3c3bd
cb9921d
f15bb00
300bb96
2413df2
a74edda
2ad6ef9
6763e41
a174dcc
840b68d
11f3c91
c497360
71b067a
3695cd8
baeba04
fd8cdfe
ae7487c
549928b
a3ea72f
917b205
a4e0c71
bab9b2d
85d8786
c16a13b
232113e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module github.com/uber/h3-go/v4 | ||
|
||
go 1.20 | ||
go 1.21 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, why change the minimum version here? Are you using a feature that only exists in 1.21? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really, usually most of the libraries support 3 latest versions of Go. Makes it easier for maintainers to maintain the package. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. As I said, I don't develop in Go, so I will leave that decision to @zachcoleman and/or @jogly There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I only care we support the versions of Go that Go cares to support (https://go.dev/doc/devel/release), and their policy is 2 versions. Go is at 1.23 now so I support dropping 1.20 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you aren't keeping 1.20 in this list and dropping it entirely?
I don't develop in Go, so not sure what the community stance is on backwards compatibility in libraries.