Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible split of this tool for other uses #30

Open
rickyp-uber opened this issue Sep 20, 2018 · 0 comments
Open

Possible split of this tool for other uses #30

rickyp-uber opened this issue Sep 20, 2018 · 0 comments

Comments

@rickyp-uber
Copy link
Collaborator

Right now there seems to be a bit of a discrepancy of data being generated due to the source of data and what this tool actually targets. For example, the data contracts from the server who owns the thrift contract and the browser itself looks something like this thrift -> tchannel -> thriftrw -> browser where at any arrow the data contract can (and does) change.

Right now thrift2flow really focuses on that last arrow thriftrw -> browser. But it bases it's information from the thrift file directly which it gets from the server. In reality, it should base it's information off the tchannel translation of this thrift file definition.

Based on this there needs to be a few tools written

  1. Flow generator based on the thrift file itself (possible integration with the thrift product similar to how they did typescript)
  2. thriftflow2tchannel converter
  3. tchannel2thriftrw converter

This would then allow for the most accurate portral of the conversions going on along with if a layer was removed in the middle somewhere, most accurate maintenance of final generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant