Wrong denominators when normalize xx_channel and yy_channel?

[jiayily]

Hi, in your code you normalize xx_channel and yy_channel as following:

CoordConv/CoordConv.py

Line 70 in 27fab8b

xx_channel = tf.cast(xx_channel, 'float32') / (self.x_dim - 1)

CoordConv/CoordConv.py

Line 71 in 27fab8b

yy_channel = tf.cast(yy_channel, 'float32') / (self.y_dim - 1)

I think it should be:
xx_channel = tf.cast(xx_channel, 'float32') / (self.y_dim - 1)
yy_channel = tf.cast(yy_channel, 'float32') / (self.x_dim - 1)
That is the denominators are wrong?

[jeanibarz]

Yes it is, there are already 2 pull requests for that issue (one created since 2020). I think that the repository is not maintained anymore.