Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log.fatal is not considered terminal #115

Closed
nicois opened this issue Nov 18, 2023 · 2 comments
Closed

Log.fatal is not considered terminal #115

nicois opened this issue Nov 18, 2023 · 2 comments

Comments

@nicois
Copy link

nicois commented Nov 18, 2023

When a nil test ends with a call to log.Fatal, the analyser does not realise that execution will end, and appears to consider it as the same as other log methods.

@ksurent
Copy link

ksurent commented Nov 20, 2023

Looks like a duplicate of #70.

@yuxincs
Copy link
Contributor

yuxincs commented Nov 22, 2023

We indeed have a lot of terminal functions (as well as other abnormal control flows) to handle. Closing this as a duplicate of #70 . Let's continue the discussion there!

Thanks @ksurent !

@yuxincs yuxincs closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants