Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better rate-limiting implementation #19

Open
justin0022 opened this issue Mar 23, 2021 · 0 comments
Open

Better rate-limiting implementation #19

justin0022 opened this issue Mar 23, 2021 · 0 comments

Comments

@justin0022
Copy link
Member

justin0022 commented Mar 23, 2021

Current rate-limiting is static, relying on https://www.npmjs.com/package/bottleneck, instead of dynamically throttling depending on the X-Rate-Limit-Remaining header on the response.

Implementing proper rate-limiting will:

  1. Improve performance, potentially dramatically.
  2. Reduce chance of accidentally hitting the rate limit when making batch changes and causing an absolute headache because it becomes difficult to determine which requests succeeded and which requests failed (as happened recently to me when running https://github.com/ubccapico/restore-speedgrader-comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant