As PC chair, you can hoturl("settings"), "\">change the deadlines.
\n"; -} - -echo "";
- if ($page > 1) {
- echo $lrg->page_link_html(1, "Newest"), " | ";
- }
- echo " | ";
- if ($page > 1) {
- echo $lrg->page_link_html($page - 1, "" . Icons::ui_linkarrow(3) . "Newer");
- }
- echo " | ";
- if ($page - $nlinks > 1) {
- echo " ...";
- }
- for ($p = max($page - $nlinks, 1); $p < $page; ++$p) {
- echo " ", $lrg->page_link_html($p, $p);
- }
- echo " | ", $page, " | ";
- for ($p = $page + 1; $p <= $page + $nlinks && $lrg->has_page($p); ++$p) {
- echo $lrg->page_link_html($p, $p), " ";
- }
- if ($lrg->has_page($page + $nlinks + 1)) {
- echo "... ";
- }
- echo " | ";
- if ($lrg->has_page($page + 1)) {
- echo $lrg->page_link_html($page + 1, "Older" . Icons::ui_linkarrow(1) . "");
- }
- echo " | ";
- if ($lrg->has_page($page + $nlinks + 1)) {
- echo " | ", $lrg->page_link_html("earliest", "Oldest");
- }
- echo " |
| Time | ', - 'User | ', - 'Affected user | ', - 'Action |
|---|
{$t}
You declined to complete this review. Thank you for informing us.
" - . Ht::form($this->conf->hoturl_post("api/declinereview", ["p" => $this->prow->paperId, "r" => $rrid, "redirect" => 1])) - . 'You have declined to complete this review. Thank you for informing us.
", 1); - } - } - - function render_accept_other_message($capuid) { - if (($u = $this->conf->cached_user_by_id($capuid))) { - if (PaperRequest::simple_qreq($this->qreq) - && ($i = $this->user->session_user_index($u->email)) >= 0) { - $selfurl = $this->conf->selfurl($this->qreq, null, Conf::HOTURL_SITEREL | Conf::HOTURL_RAW); - $this->conf->redirect(Navigation::base_absolute() . "u/{$i}/{$selfurl}"); - } else if ($this->user->has_email()) { - $mx = 'This review is assigned to ' . htmlspecialchars($u->email) . ', while you are signed in as ' . htmlspecialchars($this->user->email) . '. You can edit the review anyway since you accessed it using a special link.'; - if ($this->rrow->reviewStatus <= ReviewInfo::RS_DRAFTED) { - $m = Ht::form($this->conf->hoturl_post("api/claimreview", ["p" => $this->prow->paperId, "r" => $this->rrow->reviewId, "redirect" => 1]), ["class" => "has-fold foldc"]) - . "$mx Alternately, you can reassign it to this account.
" - . '{$mx}
"; - } - $this->conf->msg($m, 1); - } else { - $this->conf->msg( - 'This review is assigned to ' . htmlspecialchars($u->email) . '. You can edit the review since you accessed it using a special link.
', 1); - } - } - } - - function render() { - $this->pt = $pt = new PaperTable($this->user, $this->qreq, $this->prow); - $pt->resolve_review(!!$this->rrow); - $pt->resolve_comments(); - - // mode - if ($this->rv) { - $pt->set_review_values($this->rv); - } else if ($this->qreq->has_annex("after_login")) { - $rv = new ReviewValues($this->rf()); - $rv->parse_qreq($this->qreq, $this->qreq->override); - $pt->set_review_values($rv); - } - - // paper table - $this->echo_header(); - $pt->echo_paper_info(); - - if (!$this->user->can_view_review($this->prow, $this->rrow) - && !$this->user->can_edit_review($this->prow, $this->rrow)) { - $pt->paptabEndWithReviewMessage(); - } else { - if ($pt->mode === "re" || $this->rrow) { - $pt->echo_review_form(); - $pt->echo_main_link(); - } else if ($this->rrow) { - $pt->echo_rc([$this->rrow], false); - $pt->echo_main_link(); - } else { - $pt->paptabEndWithReviewsAndComments(); - } - } - - echo "\n"; - $this->conf->footer(); - } - - static function go(Contact $user, Qrequest $qreq) { - // fix request - if (!isset($qreq->m) && isset($qreq->mode)) { - $qreq->m = $qreq->mode; - } - if ($qreq->post && $qreq->default) { - if ($qreq->has_file("uploadedFile")) { - $qreq->uploadForm = 1; - } else { - $qreq->update = 1; - } - } else if ($qreq->submitreview) { - $qreq->update = $qreq->ready = 1; - } else if ($qreq->savedraft) { - $qreq->update = 1; - unset($qreq->ready); - } - - $pp = new ReviewPage($user, $qreq); - $pp->load_prow(); - - // fix user - $user->add_overrides(Contact::OVERRIDE_CHECK_TIME); - $capuid = $user->capability("@ra{$pp->prow->paperId}"); - - // action - if ($qreq->cancel) { - $pp->handle_cancel(); - } else if ($qreq->update && $qreq->valid_post()) { - $pp->handle_update(); - } else if ($qreq->adoptreview && $qreq->valid_post()) { - $pp->handle_adopt(); - } else if ($qreq->uploadForm && $qreq->valid_post()) { - $pp->handle_upload_form(); - } else if ($qreq->downloadForm) { - $pp->handle_download_form(); - } else if ($qreq->text) { - $pp->handle_download_text(); - } else if ($qreq->unsubmitreview && $qreq->valid_post()) { - $pp->handle_unsubmit(); - } else if ($qreq->deletereview && $qreq->valid_post()) { - $pp->handle_delete(); - } else if (($qreq->accept || $qreq->decline) && $capuid) { - $pp->handle_accept_decline_redirect($capuid); - } - - // capability messages: decline, accept to different user - if ($capuid) { - if (!$pp->rrow - && $pp->prow->review_refusals_by_user_id($capuid)) { - $pp->render_decline_message($capuid); - } else if ($pp->rrow - && $capuid === $pp->rrow->contactId - && $capuid !== $user->contactXid) { - $pp->render_accept_other_message($capuid); - } - } - - $pp->render(); - } -} - -ReviewPage::go($Me, $Qreq); +include("index.php"); diff --git a/reviewprefs.php b/reviewprefs.php index 3f02fdabe..871e807e2 100644 --- a/reviewprefs.php +++ b/reviewprefs.php @@ -1,229 +1,5 @@ privChair && !$Me->isPC) { - $Me->escape(); -} - -if (isset($Qreq->default) && $Qreq->defaultfn) { - $Qreq->fn = $Qreq->defaultfn; -} else if (isset($Qreq->default)) { - $Qreq->fn = "saveprefs"; -} - - -// set reviewer -$reviewer = $Me; -$incorrect_reviewer = false; -if ($Qreq->reviewer - && $Me->privChair - && $Qreq->reviewer !== $Me->email - && $Qreq->reviewer !== $Me->contactId) { - $incorrect_reviewer = true; - foreach ($Conf->full_pc_members() as $pcm) { - if (strcasecmp($Qreq->reviewer, $pcm->email) == 0 - || $Qreq->reviewer === (string) $pcm->contactId) { - $reviewer = $pcm; - $incorrect_reviewer = false; - $Qreq->reviewer = $pcm->email; - } - } -} else if (!$Qreq->reviewer && !($Me->roles & Contact::ROLE_PC)) { - foreach ($Conf->pc_members() as $pcm) { - $Conf->redirect_self($Qreq, ["reviewer" => $pcm->email]); - // in case redirection fails: - $reviewer = $pcm; - break; - } -} -if ($incorrect_reviewer) { - Conf::msg_error("Reviewer " . htmlspecialchars($Qreq->reviewer) . " is not on the PC."); -} - - -// cancel action -if ($Qreq->cancel) { - $Conf->redirect_self($Qreq); -} - - -// backwards compat -if ($Qreq->fn - && strpos($Qreq->fn, "/") === false - && isset($Qreq[$Qreq->fn . "fn"])) { - $Qreq->fn .= "/" . $Qreq[$Qreq->fn . "fn"]; -} -if (!str_starts_with($Qreq->fn, "get/") - && !in_array($Qreq->fn, ["uploadpref", "tryuploadpref", "applyuploadpref", "setpref", "saveprefs"])) { - unset($Qreq->fn); -} - -// Update preferences -function savePreferences($qreq) { - global $Conf, $Me, $reviewer, $incorrect_reviewer; - if ($incorrect_reviewer) { - Conf::msg_error("Preferences not saved."); - return; - } - - $csvg = new CsvGenerator; - $csvg->select(["paper", "email", "preference"]); - $suffix = "u" . $reviewer->contactId; - foreach ($qreq as $k => $v) { - if (strlen($k) > 7 && substr($k, 0, 7) == "revpref") { - if (str_ends_with($k, $suffix)) { - $k = substr($k, 0, -strlen($suffix)); - } - if (($p = cvtint(substr($k, 7))) > 0) { - $csvg->add_row([$p, $reviewer->email, $v]); - } - } - } - if ($csvg->is_empty()) { - Conf::msg_error("No reviewer preferences to update."); - return; - } - - $aset = new AssignmentSet($Me, true); - $aset->parse($csvg->unparse()); - if ($aset->execute()) { - Conf::msg_confirm("Preferences saved."); - $Conf->redirect_self($qreq); - } else { - Conf::msg_error(join("| ', - Ht::checkbox("showforce", 1, $pl->viewing("force"), - ["id" => "showforce", "class" => "uich js-plinfo"]), - " ", Ht::label("Override conflicts", "showforce"), " | "; - } - - echo ''; - if ($Me->privChair) - echo Ht::button("Change default view", ["class" => "ui js-edit-view-options"]), " "; - echo Ht::submit("Redisplay", array("id" => "redisplay")); - - echo " |
| - | ', "\n"; -if ($ss) { - echo ' | ', "\n"; -} -if (!$pl->is_empty()) { - echo ' | ', "\n"; -} -echo " |
As PC chair, you can hoturl("settings"), "\">change the deadlines.
\n"; + } + + echo "";
+ if ($page > 1) {
+ echo $leg->page_link_html(1, "Newest"), " | ";
+ }
+ echo " | ";
+ if ($page > 1) {
+ echo $leg->page_link_html($page - 1, "" . Icons::ui_linkarrow(3) . "Newer");
+ }
+ echo " | ";
+ if ($page - $this->nlinks > 1) {
+ echo " ...";
+ }
+ for ($p = max($page - $this->nlinks, 1); $p < $page; ++$p) {
+ echo " ", $leg->page_link_html($p, $p);
+ }
+ echo " | ", $page, " | ";
+ for ($p = $page + 1; $p <= $page + $this->nlinks && $leg->has_page($p); ++$p) {
+ echo $leg->page_link_html($p, $p), " ";
+ }
+ if ($leg->has_page($page + $this->nlinks + 1)) {
+ echo "... ";
+ }
+ echo " | ";
+ if ($leg->has_page($page + 1)) {
+ echo $leg->page_link_html($page + 1, "Older" . Icons::ui_linkarrow(1) . "");
+ }
+ echo " | ";
+ if ($leg->has_page($page + $this->nlinks + 1)) {
+ echo " | ", $leg->page_link_html("earliest", "Oldest");
+ }
+ echo " |
| Time | ', + 'User | ', + 'Affected user | ', + 'Action |
|---|
{$t}
You declined to complete this review. Thank you for informing us.
" + . Ht::form($this->conf->hoturl_post("api/declinereview", ["p" => $this->prow->paperId, "r" => $rrid, "redirect" => 1])) + . 'You have declined to complete this review. Thank you for informing us.
", 1); + } + } + + function render_accept_other_message($capuid) { + if (($u = $this->conf->cached_user_by_id($capuid))) { + if (PaperRequest::simple_qreq($this->qreq) + && ($i = $this->user->session_user_index($u->email)) >= 0) { + $selfurl = $this->conf->selfurl($this->qreq, null, Conf::HOTURL_SITEREL | Conf::HOTURL_RAW); + $this->conf->redirect(Navigation::base_absolute() . "u/{$i}/{$selfurl}"); + } else if ($this->user->has_email()) { + $mx = 'This review is assigned to ' . htmlspecialchars($u->email) . ', while you are signed in as ' . htmlspecialchars($this->user->email) . '. You can edit the review anyway since you accessed it using a special link.'; + if ($this->rrow->reviewStatus <= ReviewInfo::RS_DRAFTED) { + $m = Ht::form($this->conf->hoturl_post("api/claimreview", ["p" => $this->prow->paperId, "r" => $this->rrow->reviewId, "redirect" => 1]), ["class" => "has-fold foldc"]) + . "$mx Alternately, you can reassign it to this account.
" + . '{$mx}
"; + } + $this->conf->msg($m, 1); + } else { + $this->conf->msg( + 'This review is assigned to ' . htmlspecialchars($u->email) . '. You can edit the review since you accessed it using a special link.
', 1); + } + } + } + + function render() { + $this->pt = $pt = new PaperTable($this->user, $this->qreq, $this->prow); + $pt->resolve_review(!!$this->rrow); + $pt->resolve_comments(); + + // mode + if ($this->rv) { + $pt->set_review_values($this->rv); + } else if ($this->qreq->has_annex("after_login")) { + $rv = new ReviewValues($this->rf()); + $rv->parse_qreq($this->qreq, $this->qreq->override); + $pt->set_review_values($rv); + } + + // paper table + $this->echo_header(); + $pt->echo_paper_info(); + + if (!$this->user->can_view_review($this->prow, $this->rrow) + && !$this->user->can_edit_review($this->prow, $this->rrow)) { + $pt->paptabEndWithReviewMessage(); + } else { + if ($pt->mode === "re" || $this->rrow) { + $pt->echo_review_form(); + $pt->echo_main_link(); + } else if ($this->rrow) { + $pt->echo_rc([$this->rrow], false); + $pt->echo_main_link(); + } else { + $pt->paptabEndWithReviewsAndComments(); + } + } + + echo "\n"; + $this->conf->footer(); + } + + static function go(Contact $user, Qrequest $qreq) { + // fix request + if (!isset($qreq->m) && isset($qreq->mode)) { + $qreq->m = $qreq->mode; + } + if ($qreq->post && $qreq->default) { + if ($qreq->has_file("uploadedFile")) { + $qreq->uploadForm = 1; + } else { + $qreq->update = 1; + } + } else if ($qreq->submitreview) { + $qreq->update = $qreq->ready = 1; + } else if ($qreq->savedraft) { + $qreq->update = 1; + unset($qreq->ready); + } + if (session_id() === "" && $user->is_reviewer()) { + ensure_session(); + } + + $pp = new Review_Page($user, $qreq); + $pp->load_prow(); + + // fix user + $user->add_overrides(Contact::OVERRIDE_CHECK_TIME); + $capuid = $user->capability("@ra{$pp->prow->paperId}"); + + // action + if ($qreq->cancel) { + $pp->handle_cancel(); + } else if ($qreq->update && $qreq->valid_post()) { + $pp->handle_update(); + } else if ($qreq->adoptreview && $qreq->valid_post()) { + $pp->handle_adopt(); + } else if ($qreq->uploadForm && $qreq->valid_post()) { + $pp->handle_upload_form(); + } else if ($qreq->downloadForm) { + $pp->handle_download_form(); + } else if ($qreq->text) { + $pp->handle_download_text(); + } else if ($qreq->unsubmitreview && $qreq->valid_post()) { + $pp->handle_unsubmit(); + } else if ($qreq->deletereview && $qreq->valid_post()) { + $pp->handle_delete(); + } else if (($qreq->accept || $qreq->decline) && $capuid) { + $pp->handle_accept_decline_redirect($capuid); + } + + // capability messages: decline, accept to different user + if ($capuid) { + if (!$pp->rrow + && $pp->prow->review_refusals_by_user_id($capuid)) { + $pp->render_decline_message($capuid); + } else if ($pp->rrow + && $capuid === $pp->rrow->contactId + && $capuid !== $user->contactXid) { + $pp->render_accept_other_message($capuid); + } + } + + $pp->render(); + } +} diff --git a/src/pages/p_reviewprefs.php b/src/pages/p_reviewprefs.php new file mode 100644 index 000000000..5e68c126d --- /dev/null +++ b/src/pages/p_reviewprefs.php @@ -0,0 +1,243 @@ +select(["paper", "email", "preference"]); + $suffix = "u" . $reviewer->contactId; + foreach ($qreq as $k => $v) { + if (strlen($k) > 7 && substr($k, 0, 7) == "revpref") { + if (str_ends_with($k, $suffix)) { + $k = substr($k, 0, -strlen($suffix)); + } + if (($p = cvtint(substr($k, 7))) > 0) { + $csvg->add_row([$p, $reviewer->email, $v]); + } + } + } + if ($csvg->is_empty()) { + Conf::msg_error("No reviewer preferences to update."); + return; + } + + $aset = new AssignmentSet($user, true); + $aset->parse($csvg->unparse()); + if ($aset->execute()) { + Conf::msg_confirm("Preferences saved."); + $user->conf->redirect_self($qreq); + } else { + Conf::msg_error(join("| ', + Ht::checkbox("showforce", 1, $this->pl->viewing("force"), + ["id" => "showforce", "class" => "uich js-plinfo"]), + " ", Ht::label("Override conflicts", "showforce"), " | "; + } + + echo ''; + if ($this->user->privChair) { + echo Ht::button("Change default view", ["class" => "ui js-edit-view-options"]), " "; + } + echo Ht::submit("Redisplay", ["id" => "redisplay"]), + " |
| ', + ' | '; + if ($has_ss) { + echo ' | '; + } + if (!$this->pl->is_empty()) { + echo ' | '; + } + echo " |