-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-enabled rulesets in manifest.json are being disabled by defaultRulesetsFromLanguage
#143
Comments
There is only one enabled ruleset by default, the Also, the source code in uBOL is generated from a build script at https://github.com/gorhill/uBlock/tree/master/platform/mv3, so any change in the code needs to be done there. But as said there is only one ruleset enabled by default -- I don't plan to change this. |
Is there another way to control what lists are enabled that is not through the extension UI? |
I just noticed I haven't given any context - I'd like to manually install the extension on multiple browsers and enable specific lists as part of the installation The PR I opened just to manually control the enabled lists using the manifest.json file, but doesn't change the current defaults |
@gorhill I'd appreciate your comment on this Appreciate your work, and hope to be able to contribute to it |
I'm using uBOL in an automated / headless scenario, where users never get to interact with the browser UI and thus can not modify the rulesets. I'd also like to be able to configure the default rulesets through |
@sissbruecker sadly the fix PR was declined a few days ago without any comment or reference so I'm not sure why |
During the installation of the extension, the
defaultRulesetsFromLanguage
function uses a hard-codedout
containing the default ruleset only (on ruleset-manager.js:437) so any enabled ruleset from the manifest.json that is not "default" and the language default is being disabled during installationTo fix this, that line should be
I will open a PR on this repo hoping that's the way to contribute to this version of uBO 🙏
The text was updated successfully, but these errors were encountered: