Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectAnimation as a Resource only loads XML #52

Open
SirNate0 opened this issue Oct 14, 2023 · 1 comment
Open

ObjectAnimation as a Resource only loads XML #52

SirNate0 opened this issue Oct 14, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SirNate0
Copy link
Collaborator

ObjectAnimation supports saving to/from XML and JSON. However, when loaded as a resource through BeginLoad (e.g. through the ResourceCache), it will only load it as XML, even if you pass a JSON file. It should instead check the filename extension to deduce whether it is xml or json (or maybe even the content).
@klaussilveira klaussilveira added bug Something isn't working good first issue Good for newcomers labels Oct 24, 2023
klaussilveira added a commit that referenced this issue Oct 12, 2024
@klaussilveira
Merge pull request #72 from Okkoma/objectanimationjson
b918c5e 
ObjectAnimation as a Resource can load XML or JSON (issue #52)
@Okkoma
Copy link
Contributor

Okkoma commented Nov 14, 2024

see merged PR #72. If ok, you can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klaussilveira @SirNate0 @Okkoma