Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow deletes home directory folders #26

Open
SirNate0 opened this issue Dec 4, 2022 · 0 comments
Open

Github workflow deletes home directory folders #26

SirNate0 opened this issue Dec 4, 2022 · 0 comments
Labels
bug Something isn't working devops

Comments

@SirNate0
Copy link
Collaborator

SirNate0 commented Dec 4, 2022

I set up a self-hosted github actions runner on my mac. The "Scaffolding - cleanup" step of the macos.yml workflow deleted my projects folder on my mac.

      - name: Scaffolding - cleanup
        run: rm -rf ~/{.urho3d,projects}

This should not happen. Fortunately, I had nothing of importance in that folder, just a recently checked out copy of U3D with no important changes. But our workflow should not be creating/deleting these directories in the home folder. The directory should be chosen inside whatever "_work" directory the github runner uses, rather than in the home directory.

That, or we need to provide documentation warning of this possibility. Let's just say that if this had happened on my laptop instead of this new computer I would have been extremely unhappy.

@klaussilveira klaussilveira added bug Something isn't working devops labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops
Projects
None yet
Development

No branches or pull requests

2 participants