Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STL Containers? #20

Open
SirNate0 opened this issue Nov 29, 2022 · 1 comment
Open

STL Containers? #20

SirNate0 opened this issue Nov 29, 2022 · 1 comment

Comments

@SirNate0
Copy link
Collaborator

An issue to discuss switching to STL containers for 2.x.

From the project description, we are aiming to be (emphasis added)

Productive: Do not reinvent the wheel. Engine should reduce development time

Switching to the STL means that users have to reinvent the wheel slightly less when looking for code snippets on the internet. But it is also a significant break in compatibility with existing code, as our containers use CamelCase methods, while the STL uses snake_case.


Some questions to start off:

  1. Yes or No to switching for 2.x?
  2. Which containers (e.g. do we include String)?
  3. Which STL (the STL, EASTL, etc.)?
  4. Backwards compatibility: Is there anything to aid the user in the transition?
  5. What about where the STL is less convenient? E.g. Vector::Contains
@klaussilveira
Copy link
Contributor

I'm worried about stability. This could bring a whole new set of bugs that would be hard to find since the userbase is not that big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants