Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Report Typelevel Scala version at console welcome screen #136

Closed
soronpo opened this issue Feb 21, 2017 · 9 comments
Closed

Report Typelevel Scala version at console welcome screen #136

soronpo opened this issue Feb 21, 2017 · 9 comments

Comments

@soronpo
Copy link

soronpo commented Feb 21, 2017

If #135 comes through, I think it would be good if the Typelevel Scala version number would be displayed in the console welcome screen alongside the origin Lightbend version (and the fact that this is Typelevel Scala compiler).

@milessabin
Copy link
Member

I agree.

A PR for this should target typelevel/scala, because it really doesn't make sense for it to be a PR against scala/scala.

@soronpo
Copy link
Author

soronpo commented Apr 19, 2017

I think it would be good to have that version information available next to the Lightbend scala version.

Lightbend console

Welcome to Scala version 2.12.1 (OpenJDK 64-Bit Server VM, Java 1.8.0_121).
Type in expressions to have them evaluated.

Typelevel console (assuming 20170420 is the version number for TLS)

Welcome to Typelevel Scala version 2.12.1-20170420 (OpenJDK 64-Bit Server VM, Java 1.8.0_121).
Type in expressions to have them evaluated.

Possible implementation direction:
https://github.com/scala/scala/blob/05016d9035ab9b1c866bd9f12fdd0491f1ea0cbb/src/compiler/scala/tools/nsc/Properties.scala#L20

@milessabin
Copy link
Member

Any volunteers for this should PR against typelevel/scala (ie. this repo) rather than the usual scala/scala.

@milessabin
Copy link
Member

The form of the version will actually be 2.12.2-bin-typelevel-20170420 (-bin has special meaning for SBT). I think we probably just need a version suffix.

@soronpo
Copy link
Author

soronpo commented Apr 19, 2017

Is this what you think should be?

Welcome to Scala version 2.12.2-bin-typelevel-20170420 (OpenJDK 64-Bit Server VM, Java 1.8.0_121).
Type in expressions to have them evaluated.

Also, where in TLS sources do we expect to find the number 20170420?

@milessabin
Copy link
Member

I would imagine we would use the same mechanism that provides the existing parts of the version number? Presumably it's injected from the build somehow?

@soronpo
Copy link
Author

soronpo commented Apr 19, 2017

I tried to find this out on the scala/contributors gitter. I was referred to scala@934a314
Is a "quick and dirty" PR acceptable for the coming release, if I will create a proper PR next month?

@milessabin
Copy link
Member

"Quick and dirty" is just fine :-)

@milessabin
Copy link
Member

This is fixed in the latest TLS releases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants