Prevent deadlock when publisher is canceled #3505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
approved these changes
Nov 28, 2024
mpilquist
reviewed
Nov 29, 2024
| @@ -208,7 +208,7 @@ object Topic { | |||
| } | |||
|
|
|||
| def publish: Pipe[F, A, Nothing] = { in => | |||
| (in ++ Stream.exec(close.void)) | |||
| in.onFinalize(close.void) | |||
There was a problem hiding this comment.
Do we need the same fix in Channel
There was a problem hiding this comment.
I made the change, it should also fix #3485. But as @ValdemarGr pointed out, the exit case might not be correct.
There was a problem hiding this comment.
Here is an attempt to handle cancelation and error in Channel: e1d7b09. What do you think?
There was a problem hiding this comment.
I added this commit. Regarding Topic, I don't know how to implement the same behavior without exposing raiseError and canceled to Channel.
BalmungSan
approved these changes
Dec 1, 2024
dimitriho
force-pushed
the
topic-close
branch
2 times, most recently
from
59d9068 to
a46f858
Compare
dimitriho
force-pushed
the
topic-close
branch
from
a46f858 to
09f86e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #3502