Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Integrate intermediate steps between CommutativeRing and Field #233

Open
denisrosset opened this issue Jun 20, 2019 · 1 comment
Open

Integrate intermediate steps between CommutativeRing and Field #233

denisrosset opened this issue Jun 20, 2019 · 1 comment

Comments

@denisrosset
Copy link
Contributor

denisrosset commented Jun 20, 2019

Right now, spire has a finer grained distinction of commutative rings, namely:

  • the availability of gcd and lcm operations,
  • the availability of Euclidean division (emod, equot),

in the type classes GCDRing and EuclideanRing. As the corresponding operations are already part of the Java/Scala API for e.g. integers, it would be natural to include them in algebra. The corresponding type classes are pretty uncontroversial and map to the mathematical hierarchy.

Another step in the hierarchy, UniqueFactorizationDomain relates to the availability of factorization into prime elements. There, the API is less clear. For various reasons, this type class is present outside the ring hierarchy in Spire, and I suggest it is not included in algebra.

(There is also the story of Signed -- for abs -- and TruncatedDivision, but that should be discussed separately)

@denisrosset
Copy link
Contributor Author

See #246 and #247

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant