From 36613c23ed3ae63db0a393993616be4c1dac0e94 Mon Sep 17 00:00:00 2001 From: Ganeshwara Herawan Hananda Date: Wed, 4 Dec 2019 20:47:29 +0000 Subject: [PATCH] Add Github code owner and PR template files, and fix release pipeline issue (#7) ## What is the goal of this PR? - We have fixed a release pipeline issue causing the maven artifact to not be released - We have added Github code owner and PR template files --- .circleci/config.yml | 2 +- .github/CODEOWNERS | 1 + .github/ISSUE_TEMPLATE/BUG_REPORT.md | 41 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md | 26 ++++++++++++++ .github/ISSUE_TEMPLATE/REFACTOR.md | 15 +++++++++ .github/PULL_REQUEST_TEMPLATE.md | 12 +++++++ VERSION | 2 +- 7 files changed, 97 insertions(+), 2 deletions(-) create mode 100644 .github/CODEOWNERS create mode 100644 .github/ISSUE_TEMPLATE/BUG_REPORT.md create mode 100644 .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md create mode 100644 .github/ISSUE_TEMPLATE/REFACTOR.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.circleci/config.yml b/.circleci/config.yml index 78e7a0ae..804b4e6e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -263,7 +263,7 @@ workflows: - deploy-maven-release: filters: branches: - only: client-java-release-branch + only: common-release-branch requires: - deploy-approval - deploy-apt: diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..4bcf1054 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1 @@ +* @haikalpribadi @flyingsilverfin diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.md b/.github/ISSUE_TEMPLATE/BUG_REPORT.md new file mode 100644 index 00000000..19e4048f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.md @@ -0,0 +1,41 @@ +--- +name: Bug Report +about: Report a bug here, or visit discuss.grakn.ai for troubleshooting discussions +title: '' +labels: bug +assignees: '' + +--- + +Please replace every line in curly brackets { like this } with an appropriate answer, and remove this line. + +## Description + +{ Please provide a clear and concise description of the bug. } + +## Environment + +1. OS (where Grakn server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. } +2. Grakn version (and platform): { e.g. Grakn Core 1.4, or Grakn KGMS 1.4.3 on Google Cloud } +3. Grakn client: { e.g. client-java, client-python, client-nodejs, or console } +4. Other environment details: + +## Reproducible Steps + +Steps to create the smallest reproducible scenario: +1. { e.g. Run ... } +2. { e.g. Load ... } +3. { e.g. Query ... } +4. { e.g. See error ... } + +## Expected Output + +{ Please describe what you expected to happen. } + +## Actual Output + +{ Please describe what actually happened. } + +## Additional information + +{ Any additional information, including logs or screenshots if you have any. } diff --git a/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md new file mode 100644 index 00000000..ba741248 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md @@ -0,0 +1,26 @@ +--- +name: Feature Request +about: Request a feature here, or visit discuss.grakn.ai for ideas and questions +title: '' +labels: feature +assignees: '' + +--- + +Please replace every line in curly brackets { like this } with appropriate answers, and remove this line. + +## Problem to Solve + +{ Please describe the problem you would like to solve. } + +## Current Workaround + +{ Please describe how you currently solve or work around this problem, given Grakn's limitation. } + +## Proposed Solution + +{ Please describe the solution you would like Grakn to provide, to solve the problem above. } + +## Additional Information + +{ Any additional information, including logs or screenshots if you have any. } diff --git a/.github/ISSUE_TEMPLATE/REFACTOR.md b/.github/ISSUE_TEMPLATE/REFACTOR.md new file mode 100644 index 00000000..b454bc7e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/REFACTOR.md @@ -0,0 +1,15 @@ +--- +name: Refactor +about: Propose an architecture refactor here +labels: refactor +--- + +Please replace every line in curly brackets { like this } with appropriate answers, and remove this line. + +## Problem to Solve + +{ Please describe the problem with the current architecture that you would like to solve. } + +## Proposed Solution + +{ Please describe how you would like to change the architecture, to solve the problem above. } diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..371b2a77 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ +Please replace every line in curly brackets ( { like this } ) with an appropriate description, and remove this line. + +## What is the goal of this PR? + +{ In the form of a paragraph (only use bullet points if strictly necessary), please describe the goal of this PR, why they are valuable to achieve, and reference the related GitHub issues. This section will be automatically compiled into the release notes, so please: + - describe the impact of the change in this PR to the _user_ of this repository (e.g. end user, contributor, developer). + - describe the new product behaviour in _present tense_, and the old behaviour and how it's been changed in _past tense_. + - Use the _Royal We_: _"We"_ made changes, not _"I"_ made changes. } + +## What are the changes implemented in this PR? + +{ Please explain what you implemented, why your changes are the best way to achieve the goal(s) above, and reference the GitHub issues to be automatically closed, such like 'closes #number'. } diff --git a/VERSION b/VERSION index 0c62199f..ee1372d3 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.2.1 +0.2.2