Remove leading and trailing whitespaces from VERSION files for crate …

…and maven assembly rules (#414)

## What is the goal of this PR?

We resolve issue #380 by trimming input `version` values from `VERSION`
files for `maven` and `crate` artifacts assembly rules. It solves the
problem of `VERSION` files being passed as `version_file` to the
respective rules after being formatted to have an additional empty line
in the end, which is a standard convention for files and a common IDE
setting, or just being formatted incorrectly while containing a valid
value.

From now on, `VERSION` files passed into `assemble_maven` and
`assemble_crate` can have any leading and trailing whitespaces.

crates/CrateAssembler.kt

@@ -180,7 +180,7 @@ class CrateAssembler : Callable<Unit> {
     }
 
     private fun writeCrateArchive(config: UnmodifiableConfig) {
-        val prefix = "$name-${versionFile.readText()}"
+        val prefix = "$name-${versionFile.readText().trim()}"
         outputCrateFile.outputStream().use { fos ->
             BufferedOutputStream(fos).use { bos ->
                 GZIPOutputStream(bos).use { gzos ->
@@ -235,7 +235,7 @@ class CrateAssembler : Callable<Unit> {
             cargoToml.set<Config>("package", this)
             set<String>("name", name)
             set<String>("edition", edition)
-            set<String>("version", tagToVersion(versionFile.readText()))
+            set<String>("version", tagToVersion(versionFile.readText().trim()))
             set<Array<String>>("authors", authors.filter { it != "" })
             set<String>("homepage", homepage)
             set<String>("repository", repository)

maven/PomGenerator.kt

@@ -191,7 +191,7 @@ class PomGenerator : Callable<Unit> {
     }
 
     override fun call() {
-        val version = tagToVersion(versionFile.readText())
+        val version = tagToVersion(versionFile.readText().trim())
         val workspaceRefs = Json.parse(workspaceRefsFile.readText()).asObject()
 
         // Create an XML document for constructing the POM

maven/templates/deploy.py

@@ -81,6 +81,9 @@ def unpack_args(_, a, b=False):
 
 version = version.text
 
+if version != version.strip():
+    raise Exception('Version "{}" has leading or trailing whitespaces'.format(version))
+
 snapshot = 'snapshot'
 version_snapshot_regex = '^[0-9]+.[0-9]+.[0-9]+-[0-9|a-f|A-F]{40}$|.*-SNAPSHOT$'
 release = 'release'