Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SOLVED) ACPI ERRORS ON A T480S #196

Open
Hasodikis opened this issue Sep 2, 2023 · 0 comments
Open

(SOLVED) ACPI ERRORS ON A T480S #196

Hasodikis opened this issue Sep 2, 2023 · 0 comments

Comments

@Hasodikis
Copy link

Hasodikis commented Sep 2, 2023

This is not a bug per se, because my machine is a T480S.
It' s initially based on another EFI on GitHub with my modifications.
However I am posting this in your repo since most of the SSDTS are yours ("Tyler").

So .......

1. At kernel log after each boot, I get these ACPI ERRORS:

2023-08-25 08:50:37.970023+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:37.970025+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:37.970299+0300 localhost kernel[0]: (AppleACPIPlatform) [OINI]
2023-08-25 08:50:37.970300+0300 localhost kernel[0]: (AppleACPIPlatform) [OINI]
2023-08-25 08:50:37.970436+0300 localhost kernel[0]: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2023-08-25 08:50:37.970437+0300 localhost kernel[0]: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2023-08-25 08:50:37.971440+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/dswload-462)
2023-08-25 08:50:37.971441+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/dswload-462)
2023-08-25 08:50:37.975644+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.975645+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.976443+0300 localhost kernel[0]: (AppleACPIPlatform) During name lookup/catalog
2023-08-25 08:50:37.976444+0300 localhost kernel[0]: (AppleACPIPlatform) During name lookup/catalog
2023-08-25 08:50:37.977039+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/psobject-310)
2023-08-25 08:50:37.977040+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/psobject-310)
2023-08-25 08:50:37.981311+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.981312+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.982110+0300 localhost kernel[0]: (AppleACPIPlatform) (SSDT: _INIT) while loading table
2023-08-25 08:50:37.982110+0300 localhost kernel[0]: (AppleACPIPlatform) (SSDT: _INIT) while loading table
2023-08-25 08:50:37.982908+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-319)
2023-08-25 08:50:37.982909+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-319)
2023-08-25 08:50:37.988782+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:37.988783+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:37.989057+0300 localhost kernel[0]: (AppleACPIPlatform) [_TTS]
2023-08-25 08:50:37.989058+0300 localhost kernel[0]: (AppleACPIPlatform) [_TTS]
2023-08-25 08:50:37.989194+0300 localhost kernel[0]: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS
2023-08-25 08:50:37.989195+0300 localhost kernel[0]: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS
2023-08-25 08:50:37.990198+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/dswload-462)
2023-08-25 08:50:37.990199+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/dswload-462)
2023-08-25 08:50:37.994578+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.994579+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:37.995376+0300 localhost kernel[0]: (AppleACPIPlatform) During name lookup/catalog
2023-08-25 08:50:37.995377+0300 localhost kernel[0]: (AppleACPIPlatform) During name lookup/catalog
2023-08-25 08:50:37.995970+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/psobject-310)
2023-08-25 08:50:37.995971+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/psobject-310)
2023-08-25 08:50:38.000396+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:38.000397+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2023-08-25 08:50:38.001196+0300 localhost kernel[0]: (AppleACPIPlatform) (SSDT: _Sleep) while loading table
2023-08-25 08:50:38.001196+0300 localhost kernel[0]: (AppleACPIPlatform) (SSDT: _Sleep) while loading table
2023-08-25 08:50:38.001994+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-319)
2023-08-25 08:50:38.001995+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-319)
2023-08-25 08:50:38.006896+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:38.006897+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Error:
2023-08-25 08:50:38.007171+0300 localhost kernel[0]: (AppleACPIPlatform) 2 table load failures, 32 successful
2023-08-25 08:50:38.007172+0300 localhost kernel[0]: (AppleACPIPlatform) 2 table load failures, 32 successful
2023-08-25 08:50:38.007992+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-342)
2023-08-25 08:50:38.007993+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/tbxfload-342)

The TTS error seems to come from a duplicate method between SSDT-Sleep.aml and SSDT-LED.aml. Strange thing is sleep works.
The OINI error is more confusing to me, since I cannot file any dublicate. The only mention of this method is in SSDT-INIT.aml.

I also get this:

(AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER,
2023-08-28 21:45:35.094740+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER,
2023-08-28 21:45:35.095571+0300 localhost kernel[0]: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0
2023-08-28 21:45:35.095572+0300 localhost kernel[0]: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0
2023-08-28 21:45:35.096942+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/evrgnini-340)
2023-08-28 21:45:35.096943+0300 localhost kernel[0]: (AppleACPIPlatform) (20160930/evrgnini-340)
2023-08-28 21:45:35.103802+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI:
2023-08-28 21:45:35.103804+0300 localhost kernel[0]: (AppleACPIPlatform) ACPI:
2023-08-28 21:45:35.103951+0300 localhost kernel[0]: (AppleACPIPlatform) Executed 53 blocks of module-level executable AML code
2023-08-28 21:45:35.103952+0300 localhost kernel[0]: (AppleACPIPlatform) Executed 53 blocks of module-level executable AML code
2023-08-28 21:45:35.105276+0300 localhost kernel[0]: (AppleACPIPlatform)
2023-08-28 21:45:35.105277+0300 localhost kernel[0]: (AppleACPIPlatform)
2023-08-28 21:45:35.136423+0300 localhost kernel[0]: (AppleACPIPlatform)
ACPI: sleep states S3 S4 S5 2023-08-28 21:45:35.140383+0300 localhost kernel[0]: PMRD: setSleepSupported(1)
2023-08-28 21:45:35.140393+0300 localhost kernel[0]: PMRD: power event 7 args 0x56ee16f5727614cd 0x0
2023-08-28 21:45:35.140400+0300 localhost kernel[0]: PMRD: PowerChangeOverride (ON_STATE->ON_STATE, f,

I cannot explain this

SOLVING
PART 1:

After I lot of searching, trial and error, the OINI ACPI error is no more.
I changed the SSDT-INIT

FROM:
DefinitionBlock ("", "SSDT", 2, "tyler", "_INIT", 0x00001000)
{
External (SB.PCI0, DeviceObj)
External (SB.PCI0.RP09.INIT, MethodObj) // 0 Arguments
External (DPTF, FieldUnitObj)
External (HPTE, FieldUnitObj)
External (OSDW, MethodObj) // 0 Arguments
External (OSYS, FieldUnitObj)
External (WNTF, FieldUnitObj)
External (ZINI, MethodObj) // 0 Arguments

Scope (_SB.PCI0)
{
Method (OINI, 0, NotSerialized)
{
If (OSDW ())
{
Debug = "INIT: Set Variables..."
HPTE = Zero
WNTF = One
DPTF = Zero
OSYS = 0x07DF
}

ZINI ()
If ((OSDW () && CondRefOf (_SB.PCI0.RP09.INIT)))
{
_SB.PCI0.RP09.INIT ()
}
}
}
}

TO:
DefinitionBlock ("", "SSDT", 2, "T480", "INIT", 0x00001000)
{
External (SB.PCI0, DeviceObj)
External (DPTF, FieldUnitObj)
External (HPTE, FieldUnitObj)
External (OSYS, FieldUnitObj)
External (WNTF, FieldUnitObj)

Method (OINI, 0, NotSerialized)
{
If (_OSI ("Darwin"))
{
Debug = "Set Variables..."
HPTE = Zero
OSYS = 0x07DF
}
}
}

Is this correction valid?

PART 2
the _TTS ACPI Error disappears only when SSDT-SLEEP is disabled in OC/ACPI.

Sleep seems to work fine without this SSDT. In your docs you mention that this SSDT is for fixing sleep when dual booting with windows. If that ' s so, then on a single boot to mac os laptop, this SSDT is not necessary, correct?

The thing is every repo in github for a t480 or a t480s includes this SSDT in its configuration.

You can find my EFI here: https://github.com/Hasodikis/T480S-Hackintosh
I include an ACPI dump in my repo.

If you could help I would be grateful.

@Hasodikis Hasodikis changed the title ACPI ERRORS ON A T480S (SOLVED) ACPI ERRORS ON A T480S Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant