Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model]job.txt layer redundant? #3

Open
tylerbarna opened this issue Jul 29, 2022 · 1 comment
Open

[Model]job.txt layer redundant? #3

tylerbarna opened this issue Jul 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Owner

Reviewing the code, I'm unsure if the step that creates jobs using the [Model]job.txt scripts are really necessary. The only significant difference between them is the hard-coded definition of the number of live points and cpus as well as the specific cluster to run the job on. I realize we have each object/model fit submitted as a separate job to create a pseudo-parallelized process, but perhaps we could streamline this by creating one generic script through which the jobs are created? It's currently manageable, but it we start to add more models or create a system for dynamically adding models, it would quickly become excessively unwieldy

@tylerbarna tylerbarna added the enhancement New feature or request label Jul 29, 2022
@tylerbarna
Copy link
Owner Author

Started attempt to address this issue with creation of create_fits_script.py in 25b819e
and subsequent commits. If the specifics can be moved into settings.json and created with the script, this would make it easier to add new models and also adapt the pipeline for other systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant