Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace built-in plotting in nmma_fit.py with the new nmma functionality #15

Open
tylerbarna opened this issue Aug 26, 2022 · 1 comment
Open

Replace built-in plotting in nmma_fit.py with the new nmma functionality #15

tylerbarna opened this issue Aug 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Owner

nmma has been updated since the creation of the pipeline so that light_curve_analysis now has the --plot flag; this plots the best fit of the lightcurve, making the plotting part of nmma_fit.py redundant. Rework nmma_fit.py and any relevant scripts so they make use of the new nmma feature for plotting
@tylerbarna tylerbarna added the enhancement New feature or request label Aug 26, 2022
@tylerbarna tylerbarna mentioned this issue Aug 26, 2022
Closed
@tylerbarna
Copy link
Owner Author

Note that, because of nuclear-multimessenger-astronomy/nmma#53 , this has to be implemented in such a way that the lightcurve plots are output to their own folders per model per object lest they be overwritten. Fixing the underlying behavior in nmma would probably be the best course of action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tylerbarna