Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce wait times for overall job #11

Open
tylerbarna opened this issue Aug 15, 2022 · 3 comments
Open

Reduce wait times for overall job #11

tylerbarna opened this issue Aug 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Owner

The structure of make_jobs.py means that it won't send fits of targets until all models have been run for every target or one of them times out. This is a bit of an issue because occasionally one model gets stuck for an object (or one object gets stuck on all the models). Not sure exactly how to revise this code, but it would be good if there was some way to identify jobs that are holding the overall script back and possibly submit the other fits to be shown on slack ahead of time with some message about another job or jobs taking too long

@tylerbarna tylerbarna added the enhancement New feature or request label Aug 15, 2022
@tylerbarna
Copy link
Owner Author

Partially addressed in 56774c1 in the sense that the job time limit for the different models has been reduced from 12 to 8 hours and made it so the timeout flag in make_jobs.py is more likely to actually work, but rework would still be beneficial. Perhaps have the jobs structured in such a way that either all instances of one model or all instances of one candidate are pushed to the slack channel rather than waiting for all instances of all models for all candidates to finish to be pushed to slack channel, though this would require a rework in the way make_jobs.py submits and checks on fit jobs

@tylerbarna
Copy link
Owner Author

Reduced time further to 6 hours recently

@tylerbarna
Copy link
Owner Author

Related issue: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant