Map witness datums to tx outputs and inputs in utxorpc module #547
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a certain point in time, datums were provided in a txs witness set and not directly attached to the outputs.
As a utxorpc client, it is very difficult to figure out which datums correspond to which outputs since it would require hashing the datums in the witness set which are not in their raw form.
This PR performs the mapping of witness set datums to their corresponding outputs in the utxorpc module alleviating this hardship.
Note: This implementation works but I expect there might be a better way to things. One additional improvement would be adding the original cbor in addition to the payload but I wasn't sure how best to do this.