-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the problem causing the import error with numpy2 #800
base: main
Are you sure you want to change the base?
Conversation
The numpy is causing these errors and hindering the containers that are used. Kindly can you fast track this to main? This would at least prevent further damage. |
Hello @XotEmBotZ, I will leave this up here for those that want to manually apply to v0.3.14b. However in the original #799, the request was for a development branch fix. If you have a fix for that, development, then I have no issue applying it. Kind Regards, |
I have a question here,Since this is a non breaking change, can I know the reason for holding the merge? As this would allow the this version to be used with numpy2 till the development of v0.4 finishes. |
While it's quite likely not a breaking change, I frankly do not have the free time to address it in the event that it is. I have seen stranger things happen. 😅 It would be a different situation under different conditions. But more importantly, thanks for providing a solution. 😎 |
Nice. pip install -U git+https://github.com/twopirllc/pandas-ta downgraded my numpy from 2.1 to 1.26.4 So its not urgent to include yet, i should be able to sort myself out. |
@twopirllc any updates on this? numpy 2 is not functional and causing serious problems when trying to use this package. pandas_ta is no longer usable because many libraries now require numpy 2 |
can we please merge this and depoy? |
Since this library does not seem to be in development anymore (or doesnt seem to care about support for python 3.12) i have created a fork that works with numpy 2. See it here: https://github.com/grzesir/pandas-ta-numpy-2 |
Here's an example of using the fixed numpy 2 version in a requirements.txt lumibot>=3.8.6 |
Great initiative, thank you. I will check the functions for speed and consistency when i get to it, i was already comparing pandas-ta and TALib.
|
@grzesir : Thanks for the fix, I need this as I'm running pandas_ta inside a Github action, so manually updating the pandas_ta source file won't work for me. |
Yea same. Happy to help! |
I've used ta lib in the past and definitely prefer this library, just wish the author kept it up to date |
Hello @grzesir, @PilotGFX, @mls149 I have addressed and explained this already. 😑 Most notably in the following Issues and PRs: #799, #801, #811, #836. Please read (again) and follow any and all relevant links for extra details. Furthermore, please familiarize yourself the Guidelines. In short, based on the my replies in those posts:
Kind Regards, |
How do we use the development version? In a requirements.txt file? That sounds like a great alternative
|
Via git or Local Install. See: Pandas TA - Getting Started or Pandas TA - Development README |
fixes #799
changed NaN to nan for numpy 2.0 support