Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Column Sorting to the Entity Table Header Component #37

Open
4 tasks
MrVintage710 opened this issue Oct 5, 2024 · 0 comments
Open
4 tasks

Add Column Sorting to the Entity Table Header Component #37

MrVintage710 opened this issue Oct 5, 2024 · 0 comments
Labels
enhancement New feature or request frontend UI related work.

Comments

@MrVintage710
Copy link
Collaborator

image

Proposed Feature

To flesh out more of the usability for the tables, it would be nice if EntityTableHeaders can define there own way of sorting and sort objects. There should be a default sorting function with the ability to give your own. When clicking on a header, it should toggle between ascending, descending, and not sorting. If you click on a header other than the one that is sorting, it should clear sorting on other collumns.

Figma Link: https://www.figma.com/design/pEKOr5N9RJqUNwGoFGXN1Q/Mockups?node-id=82-33&t=Lx76vdymKdNlyPqh-1

Acceptance Criteria

  • Make sure all features are well documented with JSDoc. Here is a guide for more info.
  • Custom sorting method that can be passed as a prop to EntityTableHeader. There should be a default sorting method if one isn't provided.
  • Change table sort by clicking on the header, there should be 3 states, ascending, descending, and default. Add a prop for setting the default direction.
  • Use the carret icon to distinguish sorting direction.
@MrVintage710 MrVintage710 added enhancement New feature or request frontend UI related work. labels Oct 5, 2024
@MrVintage710 MrVintage710 added this to the Character Sheet Menu milestone Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend UI related work.
Projects
None yet
Development

No branches or pull requests

1 participant