From 9c6e01f89d0bd4db57db535000d268bff09de19e Mon Sep 17 00:00:00 2001 From: Moses Nakamura Date: Tue, 9 Nov 2021 19:24:30 +0000 Subject: [PATCH] Revert "3rdparty: jackson upgrade to 2.13.0" Problem 2.13.0 introduced a regression, where they were double-serializing. We're worried that this will lead to a substantial performance regression. Github ticket: https://github.com/FasterXML/jackson-databind/issues/3308 Solution This reverts commit e27353b784543196b9f5fd572110e4b4fe04f4c4. JIRA Issues: CSL-11459 Differential Revision: https://phabricator.twitter.biz/D780287 --- CHANGELOG.rst | 7 ------- build.sbt | 2 +- .../com/twitter/util/jackson/ScalaObjectMapperTest.scala | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 1663fc6a33..605692ff34 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -7,18 +7,11 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com Unreleased ---------- -Breaking API Changes -~~~~~~~~~~~~~~~~~~~~ - -* util-jackson: The error message when failing to deserialize a character now correctly prints the non-character string. ``PHAB_ID=D744627`` - Runtime Behavior Changes ~~~~~~~~~~~~~~~~~~~~~~~~ * util-cache: Update Caffeine cache library to version 2.9.2 ``PHAB_ID=D771893`` -* util: Bump version of Jackson to 2.13.0. ``PHAB_ID=D744627`` - 21.10.0 ------- diff --git a/build.sbt b/build.sbt index 5f65522bad..a2b7ede2aa 100644 --- a/build.sbt +++ b/build.sbt @@ -7,7 +7,7 @@ Global / excludeLintKeys += scalacOptions // might be actually unused in util-do val releaseVersion = "21.11.0-SNAPSHOT" val slf4jVersion = "1.7.30" -val jacksonVersion = "2.13.0" +val jacksonVersion = "2.11.4" val mockitoVersion = "3.3.3" val mockitoScalaVersion = "1.14.8" diff --git a/util-jackson/src/test/scala/com/twitter/util/jackson/ScalaObjectMapperTest.scala b/util-jackson/src/test/scala/com/twitter/util/jackson/ScalaObjectMapperTest.scala index 0855c4daf5..5a0579a515 100644 --- a/util-jackson/src/test/scala/com/twitter/util/jackson/ScalaObjectMapperTest.scala +++ b/util-jackson/src/test/scala/com/twitter/util/jackson/ScalaObjectMapperTest.scala @@ -823,7 +823,7 @@ class ScalaObjectMapperTest |} """.stripMargin, withErrors = Seq( - "c: '-1' is not a valid Character" + "c: '' is not a valid Character" ) ) }