You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now AcmeIssuingService._check_certs tries to renew any certificate found in the PEM objects for a server name.
I think is safe to assume that the targeted certificate is only the first one, and the rests are just CA certificates from the chain.
The other certificates can be checked for expiration, but I think that txacme can fail right away without trying to renew them, as they are not certificates that we own.
The CA chain might be expired, so the storage has invalid data... and maybe the storage itself can validate it.
Also in terms of storage errors, if due to an error, the PEM object don't contain any certificate and just a private key the cert is not added to the panicking list.
I think that we should also raise an error here... but maybe on the storage level.
The text was updated successfully, but these errors were encountered:
adiroiban
changed the title
Don't try to renew cert for the certificate chain.
Don't try to renew cert for the certificate chain and panic right away.
Oct 30, 2018
Right now AcmeIssuingService._check_certs tries to renew any certificate found in the PEM objects for a server name.
I think is safe to assume that the targeted certificate is only the first one, and the rests are just CA certificates from the chain.
The other certificates can be checked for expiration, but I think that txacme can fail right away without trying to renew them, as they are not certificates that we own.
The CA chain might be expired, so the storage has invalid data... and maybe the storage itself can validate it.
Also in terms of storage errors, if due to an error, the PEM object don't contain any certificate and just a private key the cert is not added to the panicking list.
I think that we should also raise an error here... but maybe on the storage level.
The text was updated successfully, but these errors were encountered: