Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to renew cert for the certificate chain and panic right away. #141

Open
adiroiban opened this issue Oct 30, 2018 · 0 comments
Open

Comments

@adiroiban
Copy link
Member

adiroiban commented Oct 30, 2018

Right now AcmeIssuingService._check_certs tries to renew any certificate found in the PEM objects for a server name.

I think is safe to assume that the targeted certificate is only the first one, and the rests are just CA certificates from the chain.

The other certificates can be checked for expiration, but I think that txacme can fail right away without trying to renew them, as they are not certificates that we own.

The CA chain might be expired, so the storage has invalid data... and maybe the storage itself can validate it.

Also in terms of storage errors, if due to an error, the PEM object don't contain any certificate and just a private key the cert is not added to the panicking list.
I think that we should also raise an error here... but maybe on the storage level.

@adiroiban adiroiban changed the title Don't try to renew cert for the certificate chain. Don't try to renew cert for the certificate chain and panic right away. Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant