Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall API response timeout #105

Open
mithrandi opened this issue Dec 14, 2016 · 0 comments
Open

Overall API response timeout #105

mithrandi opened this issue Dec 14, 2016 · 0 comments
Labels
Milestone

Comments

@mithrandi
Copy link
Contributor

Hypothesis: treq has a timeout for getting the request, but neither treq nor Agent have a timeout for reading the body. If the network falls over here, txacme might be stuck waiting literally forever.

I have not actually proven this hypothesis yet.

In the general case this is tricky to solve since you want a "time since last received data" or something, not a flat timeout, but in our case we can happily throw a 60 second flat timeout on top of the API client.

Unfortunately it is not possible to properly implement this because of an issue with readBody cancellation, but at least certificate issuing won't grind to a halt. (Until you run out of file descriptors. Sigh.)

@mithrandi mithrandi added the bug label Dec 14, 2016
@mithrandi mithrandi added this to the 0.9.2 release milestone Dec 14, 2016
@mithrandi mithrandi modified the milestones: 0.9.3 release, 0.9.4 release Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant