Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to being a flake8 plugin instead of using pylint #122

Open
habnabit opened this issue Dec 8, 2016 · 4 comments
Open

Switch to being a flake8 plugin instead of using pylint #122

habnabit opened this issue Dec 8, 2016 · 4 comments
Assignees

Comments

@habnabit
Copy link
Member

habnabit commented Dec 8, 2016

pyflakes is already part of the twisted workflow, as I understand it, and flake8 can be configured to not complain about twisted's disagreements with PEP8 style. flake8 is a nice general framework that checkers can be added to without much issue.

I already maintain one flake8 plugin: ebb-lint. I'm going to see what would be involved in doing this conversion, but I think the result would be more maintainable.

@habnabit habnabit self-assigned this Dec 8, 2016
@wsanchez
Copy link
Member

Perhaps better would be to provide a set of separate flake8 plugins, as some of TwistedChecker's functionality overlaps with other flake8 plugins.

For example, I think flake8_docstrings does some of what the docstrings checker does.

@adiroiban
Copy link
Member

I plan to replace a big part of twistedchecker functionality with pycodestyle (PyCQA/pycodestyle@master...adiroiban:configurable-blank-lines)

I hope that after experimenting with it, we can push a change upstream to allow some configuration for blank lines.

Beside the blank_lines, the Twisted code is pep8 compatible... so we can use it without having to ignore it.

There are a couple of checks in twistedchecker, which are not covered by pycodestyle (ex variable names)

So it would help if here we can list what plugins can we use to replace existing twistechecker checks.

@adiroiban
Copy link
Member

And twistedchecker is already using pycodestyle https://github.com/twisted/twistedchecker/blob/master/twistedchecker/checkers/pycodestyleformat.py

But I prefer to have it as an external tools so that we can use the "diff" functionality

@adiroiban
Copy link
Member

See pycodestyle issue here PyCQA/pycodestyle#732 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants