Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--diff option should be smarter about reporting duplicate errors #115

Open
glyph opened this issue Jun 29, 2016 · 1 comment
Open

--diff option should be smarter about reporting duplicate errors #115

glyph opened this issue Jun 29, 2016 · 1 comment

Comments

@glyph
Copy link
Member

glyph commented Jun 29, 2016

Presently, if you have a file that contains lots of errors, and you fix a few errors at the top, twistedchecker --diff will report that you have introduced all the errors after your fixes, if you have lengthened or shortened the code at all. #41 suggests a specific solution to this, but I wanted to open an issue to capture this specifically.

The Twisted buildbots have a somewhat smarter algorithm, which reports fewer spurious / duplicate errors. It is somewhat silly that we have two ways of implementing this ratchet; in order to facilitate moving the syntax checks to Travis-CI or another hosted service, I think that the logic implementing the always-fewer-errors ratchet should move into twistedchecker rather than buildbot.

This PR in vertex twisted/vertex#38 points towards a direction for quickly determining a baseline given a git repo on Travis.

@adiroiban
Copy link
Member

There is this project https://pypi.python.org/pypi/diff_cover

maybe we should give it a try and see if we can use it with twistedchecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants