Skip to content

Latest commit

 

History

History
31 lines (27 loc) · 2.48 KB

CommitterCheckList.mediawiki

File metadata and controls

31 lines (27 loc) · 2.48 KB
Raw

These are things that developers with commit access to the Twisted source repository should know. The first list is of policy items (i.e., things you should or should not try to do). 

  1. All development is done in branches.
  1. All code committed to trunk must go through the ReviewProcess.
  1. trunk commit messages must follow the format described on ReviewProcess so that various pieces of automation can work.
  1. If you check in something that breaks [http://buildbot.twistedmatrix.com/boxes-supported?branch=trunk&num_builds=20 trunk], revert it
  1. Everything you check in to Git is licensed under [https://github.com/twisted/twisted/blob/trunk/LICENSE Twisted's license]
  1. Be in the IRC channel, at least when you're going to be committing to trunk (don't feel bad about avoiding the distraction when you're trying to get stuff done though).
  1. Have fun, but not too much.

This second list includes various technical details about how you might go about doing Twisted development (and has overlap for organizational purposes): 

  1. All development is done in branches
    1. Branch names must follow the naming convention so that various pieces of automation can work.
  1. trunk commit messages must follow the format described on ReviewProcess so that various pieces of automation can work.
    1. If you check in something that breaks [http://buildbot.twistedmatrix.com/boxes-supported?branch=trunk&num_builds=20 trunk], revert it
      1. If the bad revision was 07c854353d,
        1. `cd ~/Projects/Twisted`
        1. `git revert -m 1 07c854353d .`
      1. Use "Reopens ticket:NNNN" in the commit message to re-open the corresponding ticket
      1. Explain what broke and how and perhaps on which platform in the commit message
    1. If you need to re-merge the reverted branch, revert the reversion. 
      1. Create a new branch or merge trunk into your branch with was previously reverted.
      1. Revert again the commit containing the revert and commit the reversion: `git revert REVERT-SHA`.
      1. Make your changes.
      1. Push the changes for re-review
  1. If you are merging a branch into trunk, you must commit exactly the merge.  You may not make extra changes in the trunk working copy after the merge.  It's easiest to do this if you merge changes via the Github pull request UI.

Other documents that overlap and supplement this information include: 

 * [http://twistedmatrix.com/documents/current/core/development/policy/svn-dev.html Working from Twisted's Code repository]
 * ReviewProcess