Dependency on pypiwin32?

[altendky]

It might be worth making an explicit dependency on pypiwin32 in setup.py for Windows installs.

[crwood]

I see that Twisted already depends on pypiwin32 for Windows installs. Are there any circumstances in which explicitly adding the dependency to qt5reactor proper would be necessary?

[altendky]

Hmm, I honestly can't recall if there was a particular case where it was an issue for me. Clearly I should have commented such. That said, it is my opinion that direct dependencies should be directly required. I suppose that would suggest also including pyqt5 and zope.interface since they are directly imported as well.

[kmike]

I think adding pyqt5 to install_requires could make things worse; it is not always possible to install pyqt5 using pip, and with pyqt5 in install_requires an innocent-looking pip install -U qt5reactor may unintentionally upgrade pyqt5 to a pip-installable version, e.g. without QtWebKit.

[aalex]

I confirm that qt5reactor requires pypiwin32 on Windows. I had to install it separately.

[altendky]

I wonder if the missing pypiwin32 is because we didn't know to install twisted[windows_platform]? I'm not sure why they don't just use the platform detection mechanisms.