-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest/tox/codecov/travis/appveyor/circle #21
Comments
@crwood or @sunu, could we get these setup?
Hopefully I'm remembering all the pieces. |
Hi @altendky, Thank you so much for taking the initiative on this! (And my apologies for the very late response here -- I was originally away when I got your mention and completely forgot to follow up...) I just tried switching on Travis-CI but, regrettably, I don't seem to have the requisite permissions (and I assume the other services will follow similarly): @sunu Any chance you could switch these on for us? |
Enabled Travis and Appveyor for now. Will enable others later if that's ok. Appveyor badge url is https://ci.appveyor.com/api/projects/status/50haxti1yjugdpya?svg=true |
bump for codecov, circle, and a review. Cheers. |
Hi @altendky, |
@sunu, I had heard bad things about Travis OS X. Really high latency for builds. I started working with CircleCI when working on Twisted. Honestly, I'm not sure why I want to use Travis at all anymore other than it being the defacto standard. It really bugs me that you can't store build artifacts there at all. Both CircleCI and AppVeyor store artifacts for you and both do Linux. Now if only we could get Linux/OS X/Windows in one place... Anyways, I'll give Travis OS X a shot. Hmm, yes, codecov is hooked up. For some reason I didn't check it off in my list... |
Well, by golly gee whiz... https://blog.travis-ci.com/2018-10-11-windows-early-release Now if only they really supported Python on either Windows or OS X. From what I've seen so far we're expected to use homebrew to get pyenv to get the Python we want. That's just silly. I may yet beat Travis into submission just for the sake of being able to go one place for everything, but it seems I'll have to build a framework of sorts for it including external storage to avoid rebuilding Python etc for every single job. On the other hand I've setup a couple of Linux and OS X configs for CircleCI without getting too horribly upset. |
I agree both that macOS testing is important and that Travis-CI is less-than-optimal for it (it's been a huge pain, in my experience, for the sorts of reasons that @altendky alludes to -- among several others...). And while I'm unfamiliar with configuring Circle-CI myself, I have heard good things about it from colleagues and wouldn't want to see @altendky's generous efforts here become squandered. @sunu Could you please enable Circle-CI for this repo and/or grant @altendky the appropriate permissions required to manage it? |
I have nothing against Circle-CI. Just that having to email them to enable OS X support was a little inconvenient and I was being lazy. Just emailed them about it now. Hopefully we'll have it enabled soon. |
@altendky I have added you as a collaborator btw. Not sure if that gives you enough access to set things up on CircleCI though. |
Just got a mail back from CircleCI saying that Mac OS builds are now enabled for this repo. |
@sunu, awesome, I'll try to get that going now. I haven't made up my mind personally on Travis. With them doing all three platforms now in one place it's tempting, but the artifact and Python situation will have to get better... Let's go with all three for now and we'll see what happens. |
Resolved by #24. |
I recently did ebroecker/canmatrix#185 so I'll presumably end up with pretty much the same thing.
The text was updated successfully, but these errors were encountered: