New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comparison to BER objects #95

Open

adiroiban opened this issue Jan 15, 2018 · 0 comments

Member

adiroiban commented Jan 15, 2018

The BER base had a naive implementation turning everything to string and the comparing this... but I think that this is wrong

At least for Integer, we should compare them as numbers.

    def __lt__(self, other):
        if not isinstance(other, BERBase):
            return NotImplemented

        return str(self) < str(other)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment