Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ActionType creates unnecessarily tight coupling between matching and execution of actions and their implementations #102

Open
exarkun opened this issue Nov 7, 2020 · 1 comment

Comments

@exarkun
Copy link
Member

exarkun commented Nov 7, 2020

The _ActionType metaclass gives the convenient Action.parse method. However, by hanging this functionality on _ActionType and Action it smashes the action parsing unit together with the action execution unit together with all of the implementations of individual actions.

What is the intended and desirable interface between wiring and action parsing? What is the intended and desirable interface exposed for executing an action? These things are difficult to see when looking at the current implementation and they are not explicitly defined anywhere outside of the implementation.

@exarkun
Copy link
Member Author

exarkun commented Nov 7, 2020

This has been on my mind for a couple days in a general way as I re-acquaint myself with the codebase. I've been thinking that the factoring of many of the units related to actions could be improved.

This came up today specifically because of #100 where I am trying to figure out where to put the code that deals with actorInterface being missing from the actor. It's hard to tell which parts of the current implementation should even know about actorInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant