-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: undefined is not an object (evaluating 'this._conversationsPromise.then') #120
Labels
bug
Something isn't working
Comments
When you remove the catch, what is the error you get? |
Also I think you should reset |
Didn't try yet but I suspect it is some connectivity error |
Yep, ok, I will take a look at that part, thank you for reporting this! |
Waiting for this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We get a lot of errors that
this._conversationsPromise
is undefined when trying to callgetSubscribedConversations
on a channel. Let's take a look atgetSubscribedConversations
:Let's look how
_ensureReady
is defined inclient.js
of@twilio/conversations
Well, it seems that there is a bug here and
await this._ensureReady
will never throw because you swallowed the error. Since you swallowed the error we get to the next linereturn this._conversationsPromise...
. But we can't be sure that_conversationsPromise
was set.You should remove that
catch
on_ensureReady
in Client constructor. At least users or your library would get the original error.The text was updated successfully, but these errors were encountered: