Add phpstan analysis #4458
Merged
Add phpstan analysis #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
phpstan
branch
from
35a5547
to
93ca91b
Compare
VincentLanglet
commented
Nov 20, 2024
src/Node/Node.php
Outdated
| @@ -186,17 +186,11 @@ public function removeAttribute(string $name): void | |||
| unset($this->attributes[$name]); | |||
| } | |||
|
|
|||
| /** | |||
| * @param string|int $name | |||
There was a problem hiding this comment.
Int is not accepted
There was a problem hiding this comment.
It is accepted explicitly in Twig 4.0 (same for all similar methods).
|
Tests were already failing and fabbot error is unrelated |
stof
reviewed
Nov 20, 2024
stof
reviewed
Nov 20, 2024
|
@VincentLanglet Can you also rebase to see (as stof fixed a bunch of test issues) |
VincentLanglet
force-pushed
the
phpstan
branch
from
8d5d33e
to
06bfe63
Compare
I rebased and added back the In the next PR I'll try to bump level 4 |
|
Thank you @VincentLanglet. |
|
There is some fixes in this PR, would it be enough for a 3.15.1 version ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @ruudk here: #4456 (comment)
I think it could be useful to add phpstan analysis on twig.
This is an example of all the things reported when checking level 3 PHPStan (more will get more errors to fix).