Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs in Add Fields Column #8699

Closed
harshit078 opened this issue Nov 23, 2024 · 4 comments
Closed

Minor bugs in Add Fields Column #8699

harshit078 opened this issue Nov 23, 2024 · 4 comments

Comments

@harshit078
Copy link
Contributor

Bug Description

  • Currently, when clicked on AddFields column it is only clickable in the plus icon div area whereas the entire column header should be clickable
  • the Plus icon should be aligned center

Current behavior

Screen.Recording.2024-11-23.at.3.57.30.PM.mov

Expected Behaviour

Screen.Recording.2024-11-23.at.4.01.37.PM.mov
@FelixMalfait
Copy link
Member

Not sure about this one @harshit078 - let's wait for @Bonapara's input. We don't want the centered (+) for sure.
We could try to make the whole bar clickable but that might be a bit more challenging than it appears to do it, I'm not sure if it's worth the effort.

@Bonapara
Copy link
Member

I agree with @FelixMalfait. We should keep the plus sign aligned to the left and could make the entire cell clickable if not too costly.

@FelixMalfait
Copy link
Member

@harshit078 let us know if you managed to make the entire cell clickable while keeping it aligned on the left and not affecting anything else in the current display (table resizing, etc.). If you don't manage to do it I think we should just close the issue for now. Thanks!

@harshit078
Copy link
Contributor Author

@FelixMalfait I agree to your point, rather than making the entire headcell clickable for which we would have to refactor some other components. We should close this issue !

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants