Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not modify case of node types when displaying non-Skyframe graphs #107

Open
benradf opened this issue Sep 10, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@benradf
Copy link
Member

benradf commented Sep 10, 2023

Problem
For Skyframe graphs, node types look LIKE_THIS in the database (which is how bazel dump shows them). Whereas in the frontend they are displayed in camel case with the underscores removed, LikeThis. Now that Skyscope supports importing arbitrary Graphviz graphs, this transformation is causing node types to be rendered in unexpected ways.

Solution
Instead of having node types transformed by the frontend just before displaying them, we should instead transform them during the import process and have the frontend display exactly what it received from the backend. The node type prefix should also be stripped from the rest of the node data, and the filter endpoint updated to search the concatenation of both. Together these changes will make Skyscope more suitable for general purpose use.

@benradf benradf added the bug Something isn't working label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant